Issue Details (XML | Word | Printable)

Key: MDL-17829
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Nicolas Connault
Reporter: Nicolas Connault
Votes: 5
Watchers: 5
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-18083

Combine category grade item and category edit forms

Created: 09/Jan/09 05:52 PM   Updated: 01/May/09 06:36 PM
Return to search
Component/s: Gradebook
Affects Version/s: 1.9.3
Fix Version/s: 1.9.5, 2.0

File Attachments: 1. Text File MDL-17829.patch (25 kB)


Participants: Matt Gibson, Nicolas Connault and Paul Ortman
Security Level: None
QA Assignee: Petr Skoda
Resolved date: 22/Apr/09
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
Currently there are two separate forms for grade categories and their associated category grade items (e.g. course category and course total). This is an endless source of confusion, and we should really try to bring these into one so that all category-related settings can be changed on one screen.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Nicolas Connault made changes - 09/Jan/09 10:06 PM
Field Original Value New Value
Status Open [ 1 ] In Progress [ 3 ]
Nicolas Connault added a comment - 09/Jan/09 10:06 PM
Attached a patch with the proposed fix.

Nicolas Connault made changes - 09/Jan/09 10:06 PM
Attachment MDL-17829.patch [ 16034 ]
Nicolas Connault added a comment - 09/Jan/09 11:03 PM - edited
You can see this patch into effect on http://test.moodle.org/1.9
username: teacher
password: testm00dle

Paul Ortman added a comment - 10/Jan/09 12:00 AM
This looks really good Nicolas! I really think this will cut down on confusion with our faculty. Thank you for taking this task on.

The only thing that I see that seems to be different from previous behavior is that clicking on the edit category button for the root (course) category show a field "Current parent aggregation" which has no value. On child categories this shows up in a "Parent Category" fieldset. I feel that on the root category it should probably not be show at all.

Also, it seems to be standard behavior, but how come the default name of the root category isn't placed in the "Category Name" field by default? It seems like that name should be in the field by default, with the user option to change the value if they feel they need or want to. No big deal, but it's always struck me as odd.

Overall, this is a great improvement IMHO. Thank you.


Nicolas Connault added a comment - 10/Jan/09 12:15 AM - edited
Thanks for the feedback, Paul.

I will remove this "informational" field from the course category form, it wasn't meant to appear there at all.

Regarding the name of the course total, what strikes you as odd is actually a default behaviour. When you create a course, this course category is automatically created, and no name is given to it. If it stays with no name, it will default to showing the course name. If the teacher wants to change its name, this will override the course name and be used instead. If he should want to revert to the course name, he can just remove the course category name entirely.

One reason for this behaviour is that we don't want to allow an empty name for any category.

It could probably be improved


Petr Skoda made changes - 22/Jan/09 02:44 AM
Fix Version/s 1.9.4 [ 10300 ]
Helen Foster made changes - 29/Jan/09 10:25 PM
Parent MDL-18083 [ 30478 ]
Issue Type Improvement [ 4 ] Sub-task [ 5 ]
Nicolas Connault committed 36 files to 'Moodle CVS' - 09/Feb/09 07:49 PM
MDL-18083 (including MDL-15680, MDL-17829, MDL-17807, MDL-18004, MDL-12631, MDL-16913)
MODIFY grade/lib.php   Rev. 1.149    (+286 -89 lines)
MODIFY grade/report/grader/index.php   Rev. 1.81    (+16 -52 lines)
MODIFY grade/edit/tree/index.php   Rev. 1.23    (+203 -117 lines)
MODIFY lang/en_utf8/gradereport_grader.php   Rev. 1.3    (+2 -1 lines)
MODIFY grade/report/grader/preferences.php   Rev. 1.30    (+2 -16 lines)
MODIFY grade/export/ods/index.php   Rev. 1.32    (+2 -8 lines)
MODIFY grade/edit/scale/index.php   Rev. 1.11    (+24 -23 lines)
MODIFY grade/edit/tree/category.php   Rev. 1.15    (+86 -15 lines)
MODIFY grade/report/grader/lib.php   Rev. 1.155    (+154 -115 lines)
MODIFY grade/edit/tree/item.php   Rev. 1.21    (+5 -10 lines)
ADD grade/edit/tree/tree.css   Rev. 1.1    (+0 -0 lines)
MODIFY grade/import/csv/index.php   Rev. 1.43    (+4 -9 lines)
ADD grade/report/grader/Attic/styles_lsu.php   Rev. 1.1    (+0 -0 lines)
ADD grade/edit/tree/lib.php   Rev. 1.1    (+0 -0 lines)
MODIFY grade/import/xml/index.php   Rev. 1.25    (+4 -8 lines)
MODIFY grade/report/grader/styles.php   Rev. 1.14    (+510 -7 lines)
MODIFY grade/edit/outcome/edit.php   Rev. 1.11    (+6 -8 lines)
MODIFY grade/edit/tree/outcomeitem.php   Rev. 1.25    (+5 -9 lines)
ADD grade/report/grader/Attic/styles_ie.css   Rev. 1.1    (+0 -0 lines)
MODIFY lang/en_utf8/grades.php   Rev. 1.177    (+18 -1 lines)
ADD grade/edit/tree/functions.js   Rev. 1.1    (+0 -0 lines)
MODIFY grade/export/xls/index.php   Rev. 1.31    (+2 -8 lines)
MODIFY grade/edit/scale/edit_form.php   Rev. 1.15    (+4 -8 lines)
MODIFY grade/edit/tree/category_form.php   Rev. 1.26    (+234 -39 lines)
MODIFY grade/report/overview/index.php   Rev. 1.9    (+11 -16 lines)
MODIFY grade/edit/outcome/index.php   Rev. 1.24    (+9 -12 lines)
MODIFY grade/edit/letter/index.php   Rev. 1.8    (+2 -10 lines)
MODIFY grade/report/lib.php   Rev. 1.46    (+7 -3 lines)
MODIFY grade/export/xml/index.php   Rev. 1.41    (+2 -8 lines)
MODIFY grade/edit/letter/edit.php   Rev. 1.10    (+2 -7 lines)
MODIFY grade/report/user/index.php   Rev. 1.37    (+17 -22 lines)
ADD grade/report/grader/Attic/styles_ie6.css   Rev. 1.1    (+0 -0 lines)
MODIFY grade/edit/outcome/course.php   Rev. 1.11    (+2 -20 lines)
MODIFY grade/report/outcomes/index.php   Rev. 1.17    (+4 -12 lines)
MODIFY grade/export/txt/index.php   Rev. 1.36    (+2 -8 lines)
MODIFY grade/edit/scale/edit.php   Rev. 1.12    (+7 -9 lines)
Nicolas Connault added a comment - 11/Feb/09 10:24 PM
Finished in HEAD. Will backport to 1.9 soon

Nicolas Connault made changes - 11/Feb/09 10:24 PM
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Nicolas Connault made changes - 11/Feb/09 10:39 PM
Fix Version/s 2.0 [ 10122 ]
Fix Version/s 1.9.5 [ 10320 ]
Nicolas Connault added a comment - 11/Feb/09 10:39 PM
Need to backport to 1.9.5

Nicolas Connault made changes - 11/Feb/09 10:39 PM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Matt Gibson added a comment - 12/Feb/09 12:26 AM
I just had a look at this and wasn't sure what 'Weight or extra credit' meant (never did know). The help pop-up wasn't a lot of use and really needs expanding by someone who knows what's going on.

Questions in my mind:

  • What does a weighted grade actually do?
  • Do all of the boxes have to have a value in them?
  • Do all the weights have to add up to 100 or some similar number?
  • What is the difference between weight and extra credit?
  • What is the unit of the number in the box? does it depend on what is selected in the dropdown?

Matt Gibson added a comment - 12/Feb/09 12:33 AM
Also, the max grade thing is a little unclear. What happens if I manually change it on one of the category totals to be more or less than the actual sum of the category items?

Also, if I set a calculation for the category total, does this make the dropdown for that category redundant? If so, it should grey out or something.


Matt Gibson added a comment - 12/Feb/09 12:36 AM
Whoops - I meant to add these comments to MDL-15680. Copying them over now.

Nicolas Connault added a comment - 12/Mar/09 05:40 PM
Matt, the max grade cannot be changed for a category set to "Sum of Grades". So your concern isn't warranted in this case. For all other aggregation types, you can set the maximum grade to anything you want, it is only really relevant when the parent category is set to "Simple weighted mean of grades", because in that case the child category's max grade determines its weight in the parent category's mean calculation.

The explanations of weight and extra credits are a separate issue, so I won't comment further here.


Nicolas Connault added a comment - 12/Mar/09 05:41 PM
Solved in 1.9.5, waiting for confirmation before sending to CVS

Nicolas Connault made changes - 12/Mar/09 05:41 PM
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Resolved [ 5 ]
Nicolas Connault made changes - 12/Mar/09 05:53 PM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Nicolas Connault committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 22/Apr/09 04:30 PM
MDL-18083 MDL-17829
Combining grade item and category forms into one
MODIFY grade/edit/tree/category_form.php   Rev. 1.9.2.16    (+259 -58 lines)
MODIFY grade/edit/tree/item_form.php   Rev. 1.20.2.20    (+20 -41 lines)
Nicolas Connault committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 22/Apr/09 04:36 PM
MDL-18083 MDL-18004 MDL-17829
Combining grade item and category forms into one. Also added new navigation code.
MODIFY grade/edit/tree/item.php   Rev. 1.14.2.5    (+5 -10 lines)
MODIFY grade/edit/tree/category.php   Rev. 1.4.2.7    (+83 -14 lines)
Nicolas Connault added a comment - 22/Apr/09 11:15 PM
Gradebook patch applied, resolving this issue.

Nicolas Connault made changes - 22/Apr/09 11:15 PM
Fix Version/s 2.0 [ 10122 ]
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Petr Skoda committed 1 file to 'Moodle CVS' - 29/Apr/09 11:15 PM
MDL-17829 category edit page cleanup
MODIFY grade/edit/tree/category_form.php   Rev. 1.30    (+1 -20 lines)
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 29/Apr/09 11:16 PM
MDL-17829 category edit page cleanup; backported from HEAD
MODIFY grade/edit/tree/category_form.php   Rev. 1.9.2.18    (+1 -20 lines)
Nicolas Connault made changes - 30/Apr/09 02:14 PM
QA Assignee nicolasconnault
Nicolas Connault made changes - 01/May/09 06:36 PM
QA Assignee nicolasconnault skodak