Moodle

Glossary auto linking setting is available when Glossary Auto-linking filter is not enabled.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.9.3, 1.9.4
  • Fix Version/s: None
  • Component/s: Glossary, Usability
  • Labels:
    None
  • Environment:
    any
  • Database:
    Any
  • Affected Branches:
    MOODLE_19_STABLE

Description

Automatically link glossary entries setting should be hidden as it is of no use if filter is not enabled and confuses users.

Issue Links

This issue has a non-specific relationship to:
MDL-17958 Glossary category linking option available when auto-linking filter is disabled and linking is disabled for glossary instance. Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Helen Foster added a comment -

Ray, thanks for your report.

+1 from me.

Reassigning to glossary component lead.

Show
Helen Foster added a comment - Ray, thanks for your report. +1 from me. Reassigning to glossary component lead.
Hide
Permalink
Ray Lawrence added a comment -

Go, glossary component lead go.... :-D

Show
Ray Lawrence added a comment - Go, glossary component lead go.... :-D
Hide
Permalink
Wen Hao Chuang added a comment - - edited

1 from me too! Also just verified that this problem still exist in latest 1.9.4 build (20090415)

Show
Wen Hao Chuang added a comment - - edited 1 from me too! Also just verified that this problem still exist in latest 1.9.4 build (20090415)
Hide
Permalink
Wen Hao Chuang added a comment - - edited

OK I have a fix and I have attached a unified diff file here. Basically this could be resolved by adding a simple if statement check at around line 57 or so in /mod/glossary/mod_form.php by doing this check:

if ($CFG->glossary_linkbydefault) { $mform->addElement('selectyesno', 'usedynalink', get_string('usedynalink', 'glossary')); $mform->setDefault('usedynalink', $CFG->glossary_linkbydefault); $mform->setHelpButton('usedynalink', array('usedynalink', get_string('usedynalink', 'glossary'), 'glossary')); } else { $mform->addElement('hidden', 'usedynalink', $usedynalink); $mform->setDefault('usedynalink', $CFG->glossary_linkbydefault); }

Thoughts or comments?

Show
Wen Hao Chuang added a comment - - edited OK I have a fix and I have attached a unified diff file here. Basically this could be resolved by adding a simple if statement check at around line 57 or so in /mod/glossary/mod_form.php by doing this check: if ($CFG->glossary_linkbydefault) { $mform->addElement('selectyesno', 'usedynalink', get_string('usedynalink', 'glossary')); $mform->setDefault('usedynalink', $CFG->glossary_linkbydefault); $mform->setHelpButton('usedynalink', array('usedynalink', get_string('usedynalink', 'glossary'), 'glossary')); } else { $mform->addElement('hidden', 'usedynalink', $usedynalink); $mform->setDefault('usedynalink', $CFG->glossary_linkbydefault); } Thoughts or comments?
Hide
Permalink
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
Hide
Permalink
Michael de Raadt added a comment -

I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Show
Michael de Raadt added a comment - I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.