[#MDL-17960] Parese error on adminlib.php, line 2536, for moodle_19_weekly

Issue Details (XML | Word | Printable)

Key:	MDL-17960
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Blocker
Assignee:	Tim Hunt
Reporter:	Andrea Bicciolo
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Parese error on adminlib.php, line 2536, for moodle_19_weekly

Created: 19/Jan/09 05:07 PM Updated: 29/May/09 04:07 PM

Return to search

Component/s:

Administration

Affects Version/s:

1.9.3

Fix Version/s:

1.9.4

Environment:

PHP 4.4.8-0 Debian

Issue Links:

Duplicate

This issue duplicates:

~~MDL-15889~~ Parse error on adminlib.php

Database:	MySQL
Participants:	Andrea Bicciolo, Petr Skoda, Sam Hemelryk and Tim Hunt
Security Level:	None
QA Assignee:	Sam Hemelryk
Resolved date:	21/Jan/09
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

A parse error occurs when updating to 1.9 weekly 2007101533.01 (build 20090114). Parse error is due to line 2536 of lib/adminlib.php

class admin_setting_users_with_capability extends admin_setting_configmultiselect {
protected $capability; <----

Commenting out line "ptotected $capability;" the parse error disappear.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Andrea Bicciolo added a comment - 19/Jan/09 05:10 PM

I forgot to mention the parse error appears only in PHP4.4.x, while in PHP 5.2.x the parse error does not occurs.

[ Permalink | « Hide ]

Andrea Bicciolo added a comment - 19/Jan/09 05:20 PM

Not sure why the issue has been considered duplicate. The MDL15880 was fixed. The parse error is now again present.

[ Permalink | « Hide ]

Petr Skoda added a comment - 19/Jan/09 06:32 PM

oh, ah - sorry, I linked wrong bug
we are trying to replicate this right now

[ Permalink | « Hide ]

Tim Hunt added a comment - 19/Jan/09 06:40 PM

Actually, the problem mentioned in this bug's description is fixed. But there is now another one:

http://moodle.org/mod/forum/discuss.php?d=114161#p501336

Parse error: syntax error, unexpected T_OBJECT_OPERATOR in ../lib/adminlib.php on line 208

Again, this is PHP4.

[ Permalink | « Hide ]

Tim Hunt added a comment - 20/Jan/09 11:48 AM

Looks like that last it was a false alarm, see the continuation of the forum thread. So re-resolving the issue. People in the forum confirm that it works now.

[ Permalink | « Hide ]

Andrea Bicciolo added a comment - 20/Jan/09 10:13 PM

Tim, I checked the current version of lib/adminlib.php in the moodle_19_weekly branch. The line 2536 is still there:

protected $capability;

This line is not parsed by PHP4.

[ Permalink | « Hide ]

Andrea Bicciolo added a comment - 20/Jan/09 10:30 PM

In teh moodle_19_table the problem has been fixed. Line 2536 of lib/adminblib.php is now:

var $capability;

which is ok. Hope this commit will go in the weekly branch this week. Anyway, the weekly branch of last week broke any admin page on PHP4 host.

Better to kkep it open just to check the weekly build ?

[ Permalink | « Hide ]

Petr Skoda added a comment - 20/Jan/09 10:42 PM

There is no weekly branch, it is just a tag in a stable branch.

[ Permalink | « Hide ]

Tim Hunt added a comment - 21/Jan/09 11:00 AM

No, entirely pointless to reopen this. There is absolutely no reason to doubt the build script. Closing again.

[ Permalink | « Hide ]

Sam Hemelryk added a comment - 29/May/09 04:07 PM

Thanks guys, everything appears to be fine now

All content on this web site is made available under the GNU General Public License, unless otherwise stated.