Moodle

Parese error on adminlib.php, line 2536, for moodle_19_weekly

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.9.4
  • Component/s: Administration
  • Labels:
    None
  • Environment:
    PHP 4.4.8-0 Debian
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

A parse error occurs when updating to 1.9 weekly 2007101533.01 (build 20090114). Parse error is due to line 2536 of lib/adminlib.php

class admin_setting_users_with_capability extends admin_setting_configmultiselect {
protected $capability; <----

Commenting out line "ptotected $capability;" the parse error disappear.

Issue Links

This issue duplicates:
MDL-15889 Parse error on adminlib.php Critical Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Bicciolo added a comment -

I forgot to mention the parse error appears only in PHP4.4.x, while in PHP 5.2.x the parse error does not occurs.

Show
Andrea Bicciolo added a comment - I forgot to mention the parse error appears only in PHP4.4.x, while in PHP 5.2.x the parse error does not occurs.
Hide
Permalink
Andrea Bicciolo added a comment -

Not sure why the issue has been considered duplicate. The MDL15880 was fixed. The parse error is now again present.

Show
Andrea Bicciolo added a comment - Not sure why the issue has been considered duplicate. The MDL15880 was fixed. The parse error is now again present.
Hide
Permalink
Petr Škoda (skodak) added a comment -

oh, ah - sorry, I linked wrong bug
we are trying to replicate this right now

Show
Petr Škoda (skodak) added a comment - oh, ah - sorry, I linked wrong bug we are trying to replicate this right now
Hide
Permalink
Tim Hunt added a comment -

Actually, the problem mentioned in this bug's description is fixed. But there is now another one:

http://moodle.org/mod/forum/discuss.php?d=114161#p501336

Parse error: syntax error, unexpected T_OBJECT_OPERATOR in ../lib/adminlib.php on line 208

Again, this is PHP4.

Show
Tim Hunt added a comment - Actually, the problem mentioned in this bug's description is fixed. But there is now another one: http://moodle.org/mod/forum/discuss.php?d=114161#p501336 Parse error: syntax error, unexpected T_OBJECT_OPERATOR in ../lib/adminlib.php on line 208 Again, this is PHP4.
Hide
Permalink
Tim Hunt added a comment -

Looks like that last it was a false alarm, see the continuation of the forum thread. So re-resolving the issue. People in the forum confirm that it works now.

Show
Tim Hunt added a comment - Looks like that last it was a false alarm, see the continuation of the forum thread. So re-resolving the issue. People in the forum confirm that it works now.
Hide
Permalink
Andrea Bicciolo added a comment -

Tim, I checked the current version of lib/adminlib.php in the moodle_19_weekly branch. The line 2536 is still there:

protected $capability;

This line is not parsed by PHP4.

Show
Andrea Bicciolo added a comment - Tim, I checked the current version of lib/adminlib.php in the moodle_19_weekly branch. The line 2536 is still there: protected $capability; This line is not parsed by PHP4.
Hide
Permalink
Andrea Bicciolo added a comment -

In teh moodle_19_table the problem has been fixed. Line 2536 of lib/adminblib.php is now:

var $capability;

which is ok. Hope this commit will go in the weekly branch this week. Anyway, the weekly branch of last week broke any admin page on PHP4 host.

Better to kkep it open just to check the weekly build ?

Show
Andrea Bicciolo added a comment - In teh moodle_19_table the problem has been fixed. Line 2536 of lib/adminblib.php is now: var $capability; which is ok. Hope this commit will go in the weekly branch this week. Anyway, the weekly branch of last week broke any admin page on PHP4 host. Better to kkep it open just to check the weekly build ?
Hide
Permalink
Petr Škoda (skodak) added a comment -

There is no weekly branch, it is just a tag in a stable branch.

Show
Petr Škoda (skodak) added a comment - There is no weekly branch, it is just a tag in a stable branch.
Hide
Permalink
Tim Hunt added a comment -

No, entirely pointless to reopen this. There is absolutely no reason to doubt the build script. Closing again.

Show
Tim Hunt added a comment - No, entirely pointless to reopen this. There is absolutely no reason to doubt the build script. Closing again.
Hide
Permalink
Sam Hemelryk added a comment -

Thanks guys, everything appears to be fine now

Show
Sam Hemelryk added a comment - Thanks guys, everything appears to be fine now

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.