Issue Details (XML | Word | Printable)

Key: MDL-17980
Type: New Feature New Feature
Status: Closed Closed
Resolution: Incomplete
Priority: Major Major
Assignee: Peter Bulmer
Reporter: Peter Bulmer
Votes: 0
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

mnet allow mass enrolments of selectable roles in mnet courses.

Created: 21/Jan/09 11:24 AM   Updated: 11/Nov/09 02:04 PM
Return to search
Component/s: Networking
Affects Version/s: 2.0
Fix Version/s: None

File Attachments: None
Image Attachments:

1. Chocolate2 Authorise Mnet Roles.png
(91 kB)

2. Course-shell.png
(160 kB)

3. cron.png
(73 kB)

4. Screenshot-Chocolate1 Map Roles.png
(108 kB)

5. specifycp.png
(84 kB)

Participants: Martin Dougiamas, Peter Bulmer and Petr Skoda
Security Level: None
Difficulty: Difficult
Affected Branches: MOODLE_20_STABLE


 Description  « Hide
As discussed with MD, and documented at
http://docs.moodle.org/en/Development:mnet_phase2

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Peter Bulmer added a comment - 02/Aug/09 12:47 PM
Interface allowing an administrator to control how local user role assignments should map to remote role assignments.

Local administrator links local roles to either nothing, or a role that is published by the remote administrator.


Peter Bulmer added a comment - 02/Aug/09 12:48 PM
Interface allowing an admistrator to specify which roles they permit a remote administrator to allocate.

Peter Bulmer added a comment - 02/Aug/09 12:52 PM
Admin view of shell course.

Peter Bulmer added a comment - 02/Aug/09 12:55 PM
Specify the course on a remote moodle that should provide the content for the local course.

Peter Bulmer added a comment - 02/Aug/09 12:59 PM
Background process creating user profiles on remote moodle, and enroling users in required courses.

Peter Bulmer added a comment - 02/Aug/09 01:03 PM
Proposed code changes.

Intend to apply this diff on head tomorrow


Martin Dougiamas added a comment - 03/Aug/09 03:17 PM
This seems rushed ... anything that makes changes to core tables needs more review, Peter...

Martin Dougiamas added a comment - 03/Aug/09 04:13 PM
Petr Skoda has reverted this check-in for us for now.

Petr Skoda added a comment - 05/Aug/09 05:30 PM
  • breaks upgrade completely - wrong DB syntax in ugprade, fatal errors before upgrade can run, etc. - apparently upgrade not tested at all
  • will have to be rewritten if we fix enrolments
  • this went in the opposite direction of convertin mnet to standard webservice plugin
  • problems with localized strings

I hoped that we would remove all mnet-isms from core db tables, instead even more were added.
In general I like this changes, but I think it should wait a bit more after we decide what to do with enrolments.

Sorry for the trouble.

Petr


Peter Bulmer added a comment - 06/Aug/09 04:17 PM
Thanks Petr,
Despite appearances the upgrade was tested in general, but not the specific path which contained the old 'update_record' I had missed. Existing mnet code in 2.0 which creates the records the upgrade was intended to deal with is broken for postgres, -> no data -> no error in testing ->

Sorry for the trouble, thanks for the time you spent rolling this back.

I'm still keen to see if your concerns can be addressed, so I'd like to explore some of them a little further:

I'm not sure what you mean by problems with localized strings - can you give me an example?

I wasn't aware of a drive to move mnet specific fields out of core tables, but I can see that this makes sense. With a little work my patch could be changed to neutralize this concern.

It makes sense to avoid changes that I will need to rework after enrolments changes, but I expect all enrolment plugins will need very similar changes, and I will have good examples to draw from.

If I recall correctly, my patch did not change underlying mnet transport mechanism, so I didn't think this patch moved us either toward, or away from web services implementation.

At present I'm trying to think my way through a plan as to if and how this patch, (and mnet enrolment/auth generally) could be dual-implemented so that it continues to work with moodle 1.9 remote peers over mnet, and can talk over web services to 2.0 remote peers, (under various scenarios). (the mnet channel could be fully removed later - 2.1?). Do you have any thoughts on this front?

Under what conditions could we proceed with an improved patch, later performing the necessary changes to accommodate changed enrolment structure?

PetEr