Moodle

Security overview report backported to 1.9 uses 2.0 API

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.9.4
  • Component/s: Administration
  • Labels:
    None
  • Environment:
    Spotted at PostgreSQL 8.3
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

admin/report/security has been recently backported from HEAD to 19_STABLE. However, some code remained using new DB API returned values. Also, some links do not work in 1.9.

Issue Links

This issue is duplicated by:
MDL-18030 Missing admin/roles/define.php in 1.9.3 weekly Major Closed
This issue has been marked as being related by:
MDL-17222 Security overview report Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Mudrak added a comment -

Fixes:

  • admin/roles/manage.php instead of new admin/roles/define.php
  • results returned by old get_recordset_sql() must be iterated using rs_fetch_next_record() instead of new foreach()
Show
David Mudrak added a comment - Fixes:
  • admin/roles/manage.php instead of new admin/roles/define.php
  • results returned by old get_recordset_sql() must be iterated using rs_fetch_next_record() instead of new foreach()
Hide
Permalink
David Mudrak added a comment -

Fixed in CVS, please review and close

Show
David Mudrak added a comment - Fixed in CVS, please review and close
Hide
Permalink
Petr Škoda (skodak) added a comment -

ooops, thanks going to review later today

Show
Petr Škoda (skodak) added a comment - ooops, thanks going to review later today
Hide
Permalink
Petr Škoda (skodak) added a comment -

thanks!

Show
Petr Škoda (skodak) added a comment - thanks!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.