Moodle

Move selected questions to page broken in Order and paging tab

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Quiz
  • Labels:
    None
  • Difficulty:
    Moderate
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

I think this worked last time I checked, but now that I updated from repository, nothing happens when selecting a question and writing a question number in the field, and clicking "Move". I did not find anything though in the commits after my last commit that would obviously break it, so I will have to leave it to you, Tim to see what is wrong.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

This is almost certainly a regression caused by my recent changes. I'll fix it.

Show
Tim Hunt added a comment - This is almost certainly a regression caused by my recent changes. I'll fix it.
Hide
Permalink
Tim Hunt added a comment -

Looks like I deleted the function array_add_at at some point, thinking it was no longer used.
http://cvs.moodle.org/moodle/mod/quiz/editlib.php?r1=1.102&r2=1.103

Doh!

Show
Tim Hunt added a comment - Looks like I deleted the function array_add_at at some point, thinking it was no longer used. http://cvs.moodle.org/moodle/mod/quiz/editlib.php?r1=1.102&r2=1.103 Doh!
Hide
Permalink
Tim Hunt added a comment -

Fixed now. Actually, we don't need a separate function, you can do it with array_splice.

Show
Tim Hunt added a comment - Fixed now. Actually, we don't need a separate function, you can do it with array_splice.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.