Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.9.3
-
Component/s: Database activity module
-
Labels:None
-
Affected Branches:MOODLE_19_STABLE
-
Fixed Branches:MOODLE_19_STABLE, MOODLE_20_STABLE
Description
In the Modules & Plugins database, search for a plugin, for example 'lightbox' and view the returned entry.
Click 'Add comment'.
You're now adding a comment to the '123flashchat module', where you'll notice others have had the same problem as there are a number of comments relating to different modules...
Attachments
Issue Links
| This issue duplicates: | ||||
| MDLSITE-586 | in particular circumstances you can't add comments to modules and plug-in |
|
|
|
| This issue is duplicated by: | ||||
| MDLSITE-671 | the "Modules and plugins" page delivers a incorrect page |
|
|
|
| MDLSITE-545 | In a search results over modules and plugins list, when try to add comments to a particular module, comments are posted to another module |
|
|
|
| This issue has a non-specific relationship to: | ||||
| MDL-18136 | Database pagination broken when searching for entries |
|
|
|
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Attaching patch that changes current behaviour of the "Add Comment" link from the "floating" page identification to use the "record->id" more deterministic one. Seems to be working ok here and I cannot imagine any drawback).
Ciao 
Assigning to Dongsheng and addressing for 1.9.5. Please test & apply.
Also, Dong, I'd recommend to, once applied, say to Martin about this (and MDL-18136) in order to get moodle.org database module updated asap.
Ciao
Just noticed this was reverted by mistake in:
http://cvs.moodle.org/moodle/mod/data/lib.php?r1=1.137.2.50&r2=1.137.2.51
So I've reapplied it. Ciao
Paul, thanks for your report.
It seems that having &filter=1 in the URL (from doing the search previously) results in the problem of the comment being added to the wrong entry i.e.
http://moodle.org/mod/data/view.php?d=13&rid=1021 - comment added to correct entry
http://moodle.org/mod/data/view.php?d=13&rid=1021&filter=1 - comment added to wrong entry
Eloy, is it possible for this issue to be fixed in 1.9.5, as it seems to be causing an increasing amount of confusion in the modules and plugins database on moodle.org.