Moodle

more information needed for unsupported role assignments

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.9.5
  • Component/s: Administration
  • Labels:
    None
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

The text on the detail page says: "It is recommended to assign administrator role in system context only. Following users have unsupported admin role assignments", but it doesn't say in which context the problem exists.

Issue Links

This issue is duplicated by:
MDL-18259 Hard to find "unsupported role assignment" Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Koen Roggemans added a comment -

Sorry, forgot to mention which detail page.
The detail page of "Administrators":
moodle/admin/report/security/index.php?issue=report_security_check_riskadmin

Show
Koen Roggemans added a comment - Sorry, forgot to mention which detail page. The detail page of "Administrators": moodle/admin/report/security/index.php?issue=report_security_check_riskadmin
Hide
Permalink
Martin Dougiamas added a comment -

Yes, a table showing the role assignments would be ideal here.

Show
Martin Dougiamas added a comment - Yes, a table showing the role assignments would be ideal here.
Hide
Permalink
Petr Škoda (skodak) added a comment -

yes, this should be relatively easy.

Show
Petr Škoda (skodak) added a comment - yes, this should be relatively easy.
Hide
Permalink
Petr Škoda (skodak) added a comment -

fixed in cvs, thanks for the report

Show
Petr Škoda (skodak) added a comment - fixed in cvs, thanks for the report
Hide
Permalink
Helen Foster added a comment -

Koen, thanks for your report, and Petr, thanks for your fix, which works perfectly (I tried assigning users in the course category, course, and activity contexts - all were detected) however it's unclear that you have to follow the user name link to fix the problem.

Thus, I'm reopening this issue and hoping it can be fixed as follows (or in a similar way):

----------------------------------

Please verify the following list of system administrators:

  • Admin User (admin@school.a)

It is recommended that the role of admin is assigned in the system context only. The following users have unsupported admin role assignments:

  • Teacher (teacher@school.a) Remove this role assignment
  • Student (student@school.a) Remove this role assignment

----------------------------------

where in each case the user name links to the profile page, and 'Remove this role assignment' is a link to fix the problem.

Show
Helen Foster added a comment - Koen, thanks for your report, and Petr, thanks for your fix, which works perfectly (I tried assigning users in the course category, course, and activity contexts - all were detected) however it's unclear that you have to follow the user name link to fix the problem. Thus, I'm reopening this issue and hoping it can be fixed as follows (or in a similar way): ---------------------------------- Please verify the following list of system administrators:
  • Admin User (admin@school.a)
It is recommended that the role of admin is assigned in the system context only. The following users have unsupported admin role assignments:
  • Teacher (teacher@school.a) Remove this role assignment
  • Student (student@school.a) Remove this role assignment
---------------------------------- where in each case the user name links to the profile page, and 'Remove this role assignment' is a link to fix the problem.
Hide
Permalink
Petr Škoda (skodak) added a comment -

should be fixed now

Show
Petr Škoda (skodak) added a comment - should be fixed now
Hide
Permalink
Helen Foster added a comment -

Petr, thanks for your further work on this issue. It's much better now, however the extra-long link (the whole of 'Sam Student (student@school.a) review role assignment') looks a bit odd to me.

How about just having 'Review this role assignment' as a link?

An even better solution would be to mention the context of the role assignment e.g. 'Review this role assignment in the category context', 'Review this role assignment in the course context' etc.

Show
Helen Foster added a comment - Petr, thanks for your further work on this issue. It's much better now, however the extra-long link (the whole of 'Sam Student (student@school.a) review role assignment') looks a bit odd to me. How about just having 'Review this role assignment' as a link? An even better solution would be to mention the context of the role assignment e.g. 'Review this role assignment in the category context', 'Review this role assignment in the course context' etc.
Hide
Permalink
Petr Škoda (skodak) added a comment -

Name of user is the important information, why should we leave that out?

Show
Petr Škoda (skodak) added a comment - Name of user is the important information, why should we leave that out?
Hide
Permalink
Helen Foster added a comment -

Sorry, I didn't mean for the user name to be left out, I just thought it looked odd to be included in the review role assignment link.

IMO we should be consistent and have all user names linking to profile pages, and just have the text 'Review this role assignment' as a link to fix the problem.

Show
Helen Foster added a comment - Sorry, I didn't mean for the user name to be left out, I just thought it looked odd to be included in the review role assignment link. IMO we should be consistent and have all user names linking to profile pages, and just have the text 'Review this role assignment' as a link to fix the problem.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.