[#MDL-18044] Notice from forum ratings and wrong add scale instructions

Issue Details (XML | Word | Printable)

Key:	MDL-18044
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Minor
Assignee:	Tim Hunt
Reporter:	Tim Hunt
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Notice from forum ratings and wrong add scale instructions

Created: 27/Jan/09 03:32 PM Updated: 11/Jun/09 10:38 AM

Return to search

Component/s:

Forum

Affects Version/s:

1.9.3

Fix Version/s:

1.9.4

Participants:	Sam Hemelryk and Tim Hunt
Security Level:	None
QA Assignee:	Sam Hemelryk
Resolved date:	27/Jan/09
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

Notice: Undefined property: stdClass::$assesstimestart in /srv/www/htdocs/moodle_19/mod/forum/lib.php on line 3016 when you have ratings selected, but not using a scale.

All

Comments

Change History

Version Control

Sort Order:

Tim Hunt made changes - 27/Jan/09 03:33 PM

Field	Original Value	New Value
Summary	Notice from forum ratings	Notice from forum ratings and wrong add scale instructions

tjhunt committed 3 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 27/Jan/09 03:35 PM

forum rating: ~~MDL-18044~~ notice sometimes when a forum is rated, also XHTML strict problems and fix incorrect help text.

MODIFY	mod/forum/lib.php	Rev. 1.609.2.83	(+4 -4 lines)
MODIFY	lang/en_utf8/moodle.php	Rev. 1.141.2.55	(+2 -1 lines)
MODIFY	course/scales.php	Rev. 1.32.2.2	(+4 -3 lines)

tjhunt committed 3 files to 'Moodle CVS' - 27/Jan/09 03:35 PM

forum rating: ~~MDL-18044~~ notice sometimes when a forum is rated, also XHTML strict problems and fix incorrect help text.

MODIFY	course/scales.php	Rev. 1.39	(+4 -3 lines)
MODIFY	mod/forum/lib.php	Rev. 1.770	(+4 -3 lines)
MODIFY	lang/en_utf8/moodle.php	Rev. 1.226	(+2 -1 lines)

[ Permalink | « Hide ]

Tim Hunt added a comment - 27/Jan/09 03:38 PM

The wrong help text was on course/scales.php, which you get to by clicking the help icon next to Grade field on the forum settings form. (That page also had XHTML strict problems.)

The notice came from turning on ratings by setting Aggregate type to something, but then leaving Grade on 'No grade'.

Tim Hunt made changes - 27/Jan/09 03:38 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

martignoni committed 1 file to 'Lang CVS' - 28/Jan/09 03:05 AM

~~MDL-18044~~ New string

MODIFY

fr_utf8/moodle.php

Rev. 1.278

(+2 -1 lines)

martignoni committed 1 file to 'Lang CVS' - 28/Jan/09 03:07 AM

~~MDL-18044~~, String enhanced

MODIFY

fr_utf8/moodle.php

Rev. 1.279

(+2 -2 lines)

Mitsuhiro Yoshida committed 6 files to 'Lang CVS' - 28/Jan/09 02:31 PM

~~MDL-18044~~ Translated a new string for creating custom scales.
Brushed up a translated help file for qtype multianswer more XHTML strict based on lang/en_utf8 change.
~~MDL-17679~~ Translated a new string for hotpot.
~~MDL-18015~~ Translated a new string for security report.
MDL-17365 Translated a new string for forum rate.

MODIFY	ja_utf8/moodle.php	Rev. 1.345	(+1 -0 lines)
MODIFY	ja_utf8/help/qtype_multianswer/multianswer.html	Rev. 1.4	(+6 -7 lines)
MODIFY	ja_utf8/README	Rev. 1.928	(+1 -1 lines)
MODIFY	ja_utf8/hotpot.php	Rev. 1.34	(+2 -1 lines)
MODIFY	ja_utf8/report_security.php	Rev. 1.11	(+2 -1 lines)
MODIFY	ja_utf8/forum.php	Rev. 1.84	(+2 -1 lines)

[ Permalink | « Hide ]

Sam Hemelryk added a comment - 11/Jun/09 10:38 AM

Confirmed thanks Tim, everything looks good now

Sam Hemelryk made changes - 11/Jun/09 10:38 AM

Status	Resolved [ 5 ]	Closed [ 6 ]
QA Assignee		samhemelryk

All content on this web site is made available under the GNU General Public License, unless otherwise stated.