[#MDL-18051] Quiz regrade gives error with debugging set to max - Moodle Tracker

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.9.3
Fix Version/s: 1.9.6
Component/s: Quiz
Labels:
None

Affected Branches:
MOODLE_19_STABLE
Fixed Branches:
MOODLE_19_STABLE

Description

I just regraded a quiz, which uses only short answer an multiple choice questions. I had previously altered the overall feedback settings, but nothing else. I got the following error loads of times at the bottom of the screen, after all the regradings had happened. It went OK it seems other than that.

Notice: Undefined offset: -2 in E:\Moodle_webserver\moodle\lib\evalmath\evalmath.class.php on line 425

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Sam Marshall added a comment - 21/May/09 7:44 PM

We are seeing the same thing here. It appears to be caused by an error in the evalmath class which is used for calculated grades.

To reproduce:

error_reporting(E_ALL);
$silly = new EvalMath();
$silly->nfx('(gi6-20+1)/(2*(gi6-20+0.5))');

The actual results of the function appear to be correct, so this warning does not do any harm, but it is rather disturbing.

Show

Sam Marshall added a comment - 21/May/09 7:44 PM We are seeing the same thing here. It appears to be caused by an error in the evalmath class which is used for calculated grades. To reproduce: error_reporting(E_ALL); $silly = new EvalMath(); $silly->nfx('(gi6-20+1)/(2*(gi6-20+0.5))'); The actual results of the function appear to be correct, so this warning does not do any harm, but it is rather disturbing.

Hide

Permalink

Sam Marshall added a comment - 21/May/09 7:50 PM

OK, I found it. The bug is:

When you close a bracket, it looks at the token before the open-bracket (on its stack) to see if it is a function call.

It does this even if there is no token before the open-bracket

So you will get this warning for each bracket in the expression that isn't a function call.

Will fix shortly.

Show

Sam Marshall added a comment - 21/May/09 7:50 PM OK, I found it. The bug is:

When you close a bracket, it looks at the token before the open-bracket (on its stack) to see if it is a function call.

It does this even if there is no token before the open-bracket

So you will get this warning for each bracket in the expression that isn't a function call.

Will fix shortly.

Hide

Permalink

Petr Škoda (skodak) added a comment - 21/May/09 7:55 PM

thanks!

Show

Petr Škoda (skodak) added a comment - 21/May/09 7:55 PM thanks!

Hide

Permalink

Sam Marshall added a comment - 21/May/09 7:58 PM

This is also reproducible with the expression (1+1)

I changed the logic for the last() function involved here so that instead of giving a debugging warning if you ask for something off the end of the stack, it returns null. This is analogous to the pop() function.

While this basically just gets rid of the warning without fixing anything I did verify that the warning was harmless - the postfix version of the expression is correct.

Show

Sam Marshall added a comment - 21/May/09 7:58 PM This is also reproducible with the expression (1+1) I changed the logic for the last() function involved here so that instead of giving a debugging warning if you ask for something off the end of the stack, it returns null. This is analogous to the pop() function. While this basically just gets rid of the warning without fixing anything

I did verify that the warning was harmless - the postfix version of the expression is correct.

Hide

Permalink

Sam Hemelryk added a comment - 04/Jun/09 1:23 PM

Confirmed, no error message shown. Thanks

Show

Sam Hemelryk added a comment - 04/Jun/09 1:23 PM Confirmed, no error message shown. Thanks

People

Assignee:

Sam Marshall

Reporter:

Matt Gibson

Tester:

Sam Hemelryk

Participants:

Matt Gibson, Petr Škoda (skodak), Sam Hemelryk, Sam Marshall

Vote (0)

Watch (3)

Dates

Created:

27/Jan/09 10:07 PM

Updated:

04/Jun/09 1:23 PM

Resolved:

21/May/09 7:58 PM