Moodle

Course participation report doesn't allow you to select which actions to show

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.4
  • Fix Version/s: 1.9.5
  • Component/s: Course, Other
  • Labels:
    None
  • Environment:
    PHP 5.2.6 (cli) (built: Jul 29 2008 16:20:31)
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

When selecting 'Reports > Participation report' in a Moodle course you can't change the 'Show actions' select box to filter only view/post participation for an activity.

The following code (/course/report/participation/index.php) always evaluates to false, resetting the $action variable:

$actionoptions = array('' => $strallactions,
'view' => $strview,
'post' => $strpost,);
if (!in_array($action, $actionoptions)) { $action = ''; }

Changing the in_array test to use array_keys($actionoptions) allows you to filter different actions

Issue Links

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Well spotted Paul!

Fix applied to 19_STABLE and HEAD. Resolving as fixed. Thanks!

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Well spotted Paul! Fix applied to 19_STABLE and HEAD. Resolving as fixed. Thanks! Ciao
Hide
Helen Foster added a comment -

Paul, thanks for your report, and Eloy thanks for applying the fix. I've tested with the latest 1.9.4+ and found everything working perfectly.

Show
Helen Foster added a comment - Paul, thanks for your report, and Eloy thanks for applying the fix. I've tested with the latest 1.9.4+ and found everything working perfectly.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: