Moodle

Database module doesn't respect mod/data:comment capability when adding comments

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.4
  • Fix Version/s: 1.9.5, 2.0
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

The Database module doesn't seem to respect the 'mod/data:comment' capability anywhere in it's code (in fact grep'ing for it returns only it's definition in /db/access.php).

Probably should be checked before printing the link to add a comment in the data_print_comments function (lib.php), and maybe a catch-all require_capability call in comment.php?

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Assigning to Dongsheng and adressing for 1.9.5

Dong, can you, please, check how it's working and verify where the capability check is missing, fixing that? TIA!

Thanks for report, Paul!

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Dongsheng and adressing for 1.9.5 Dong, can you, please, check how it's working and verify where the capability check is missing, fixing that? TIA! Thanks for report, Paul!
Hide
Dongsheng Cai added a comment -

Fixed, thanks for reporting, Paul.

Show
Dongsheng Cai added a comment - Fixed, thanks for reporting, Paul.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: