Moodle

Entering a forum discussion produces a fatal error in 1.9.4 stable

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Not a bug
  • Affects Version/s: 1.9.4
  • Fix Version/s: None
  • Component/s: Forum
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

The error produced is require_js: http://moodlehacks.com/lib/yui/json/json-min.js - file not found.

when page mod/forum/discuss.php?d=7 is called.

The error goes away when yui_json s removed from the require_js call in discuss.php.

To reproduce, simply create a discussion with one topic.

Then go back an try to read the discussion.

Observed on our discussion server and then confirmed on two test servers. It appears to be a change that is at least a few days old.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Hi Gary,

that file (lib/yui/json/json-min.js) is there since ages ago, see http://cvs.moodle.org/moodle/lib/yui/json/?pathrev=MOODLE_19_STABLE

Looking your server, it seems that the whole yui/json folder is missing. Perhaps your latest update was wrong (incomplete or so)?

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Hi Gary, that file (lib/yui/json/json-min.js) is there since ages ago, see http://cvs.moodle.org/moodle/lib/yui/json/?pathrev=MOODLE_19_STABLE Looking your server, it seems that the whole yui/json folder is missing. Perhaps your latest update was wrong (incomplete or so)? Ciao
Hide
Permalink
Gary Anderson added a comment -

OK. It is weird that none of our three servers have the json folder and that a cvs update does not add it for us.

I suspect that it has to do with our CVS instruction and how it treats the case when a new directory is added into core.

Let's keep this open for a few more hours until this is fully understood and I will post something to the docs about what to do when this problem happens. But I have confirmed that the json filter is in both the US and UK cvs for 1.9 stable.

Show
Gary Anderson added a comment - OK. It is weird that none of our three servers have the json folder and that a cvs update does not add it for us. I suspect that it has to do with our CVS instruction and how it treats the case when a new directory is added into core. Let's keep this open for a few more hours until this is fully understood and I will post something to the docs about what to do when this problem happens. But I have confirmed that the json filter is in both the US and UK cvs for 1.9 stable.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

cvs [-q] update -dPr MOODLE_19_WEEKLY

should force new stuff to come (d) plus empty dirs to be deleted (P) to get the latest revision (r) of MOODLE_19_WEEKLY (the recommended one). With one optional -q to be quiet on output of the progress.

Just in case it helps...ciao

Show
Eloy Lafuente (stronk7) added a comment - cvs [-q] update -dPr MOODLE_19_WEEKLY should force new stuff to come (d) plus empty dirs to be deleted (P) to get the latest revision (r) of MOODLE_19_WEEKLY (the recommended one). With one optional -q to be quiet on output of the progress. Just in case it helps...ciao
Hide
Permalink
Gary Anderson added a comment -

Closing this non-bug. It is apparently a problem with incorrect cvs commands as the json library is in core. It may be useful as a reference in case someone else reports a similar problem.

Thanks, Eloy

Show
Gary Anderson added a comment - Closing this non-bug. It is apparently a problem with incorrect cvs commands as the json library is in core. It may be useful as a reference in case someone else reports a similar problem. Thanks, Eloy
Hide
Permalink
Manish Verma added a comment -

It appears that Moodle 1.9 download packs (both .zip and .tgz) do not have the folder /lib/yui/json/ .

Show
Manish Verma added a comment - It appears that Moodle 1.9 download packs (both .zip and .tgz) do not have the folder /lib/yui/json/ .
Hide
Permalink
Martin Dougiamas added a comment -

I just checked the 1.9.4 packs and they are there. This directory was not (needed) in 1.9 though.

Show
Martin Dougiamas added a comment - I just checked the 1.9.4 packs and they are there. This directory was not (needed) in 1.9 though.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.