Moodle

Unwanted text (MP3 audio) is shown when using the mp3-player

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Duplicate
  • Affects Version/s: 1.9.4
  • Fix Version/s: None
  • Component/s: Filters
  • Labels:
    None
  • Environment:
    -

Description

In the new version of Moodle (1.9.4) the unwanted text (MP3 audio) is shown when the mp3-player is used.
This happens for example in a test where questions with audio.
I think that the problem is in the file filter\mediaplugin\filter.php
This is the only file in this folder that changed compared to an earlier version of Moodle.
The problem was fixed by copying the entire filter\mediaplugin folder from an older version to the newer version so I'm not 100% sure but the problem is in this folder,

See the attachment for a picture of this error (it's a question in a Dutch test)

Issue Links

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Hi,

I've been looking for changes in the multimedia filter... and those strings (for mp3, swf and flv contents) have been there since March 2007.

While I agree that it can be far from optimal in some circumstances I don't know if there is any reason (accessibility or readability or...) for that, so I've added some watchers to this track.

Until then, I'd suggest you to change this style in standard theme from:

.mediaplugin_mp3, .mediaplugin_swf, .mediaplugin_flv {
display:inline;
clear:none;
margin:0px;
margin-left:0.5em;
}

to

.mediaplugin_mp3, .mediaplugin_swf, .mediaplugin_flv {
display:none;
clear:none;
margin:0px;
margin-left:0.5em;
}

That should do the trick for your server. It's far better than using filters from older versions.

My +1 goes about to hide the texts by default, though need some comments from experts. Stay tuned. Ciao

Show
Eloy Lafuente (stronk7) added a comment - Hi, I've been looking for changes in the multimedia filter... and those strings (for mp3, swf and flv contents) have been there since March 2007. While I agree that it can be far from optimal in some circumstances I don't know if there is any reason (accessibility or readability or...) for that, so I've added some watchers to this track. Until then, I'd suggest you to change this style in standard theme from: .mediaplugin_mp3, .mediaplugin_swf, .mediaplugin_flv { display:inline; clear:none; margin:0px; margin-left:0.5em; } to .mediaplugin_mp3, .mediaplugin_swf, .mediaplugin_flv { display:none; clear:none; margin:0px; margin-left:0.5em; } That should do the trick for your server. It's far better than using filters from older versions. My +1 goes about to hide the texts by default, though need some comments from experts. Stay tuned. Ciao
Hide
Eloy Lafuente (stronk7) added a comment -

Linking to original discussion in forums

Show
Eloy Lafuente (stronk7) added a comment - Linking to original discussion in forums
Hide
Artem Andreev added a comment -

Same problem as in MDL-18226.

Show
Artem Andreev added a comment - Same problem as in MDL-18226.
Hide
Lukasz Sanokowski added a comment -

I changed file styles_layout.css as Eloy wrote. After changing display:inline; to display:none unwanted text disappeared, but embedded flash object disappeared also :/

Regards

Show
Lukasz Sanokowski added a comment - I changed file styles_layout.css as Eloy wrote. After changing display:inline; to display:none unwanted text disappeared, but embedded flash object disappeared also :/ Regards
Hide
Eloy Lafuente (stronk7) added a comment -

Closing this as duplicate of MDL-18226. Thanks Artem.

Show
Eloy Lafuente (stronk7) added a comment - Closing this as duplicate of MDL-18226. Thanks Artem.
Hide
Don Hinkelman added a comment -

Thank you, Eloy, for fixing this little irritation. I almost had to manually remove 300 unwanted "(MP3 audio)" texts.

Since we just upgraded to 1.9.4 a few days before this was fixed, our site admin would like to know the exact php file where this was fixed. That would save upgrading the whole site.

Show
Don Hinkelman added a comment - Thank you, Eloy, for fixing this little irritation. I almost had to manually remove 300 unwanted "(MP3 audio)" texts. Since we just upgraded to 1.9.4 a few days before this was fixed, our site admin would like to know the exact php file where this was fixed. That would save upgrading the whole site.
Hide
Eloy Lafuente (stronk7) added a comment -

Note this is being handled in MDL-17703 now

Show
Eloy Lafuente (stronk7) added a comment - Note this is being handled in MDL-17703 now

Dates

  • Created:
    Updated:
    Resolved: