|
|
|
When working in the Windows installer, I've detected that threre are some problems with back & forward slashes in the installer:
dirroot is calculated with dirname() that uses "native" windows backslashes.
dataroot is calculated with moodle stuff, that always use forwardslashes
Later, dirroot is written with forwardslashes.
And then, later, in admin/index.php, dirroot is checked again with realpath(), and that doesn't pass the test when comparing back & forward slashed dirroots.
So I'm going to:
0) After chat with Sam, use always forward-slashes seems to be ok.
1) Change install to suggest forward-slashed dirroot.
2) Change admin/index.php check to ignore back & forward slashes differences.
Ciao :-)
|
|
Description
|
When working in the Windows installer, I've detected that threre are some problems with back & forward slashes in the installer:
dirroot is calculated with dirname() that uses "native" windows backslashes.
dataroot is calculated with moodle stuff, that always use forwardslashes
Later, dirroot is written with forwardslashes.
And then, later, in admin/index.php, dirroot is checked again with realpath(), and that doesn't pass the test when comparing back & forward slashed dirroots.
So I'm going to:
0) After chat with Sam, use always forward-slashes seems to be ok.
1) Change install to suggest forward-slashed dirroot.
2) Change admin/index.php check to ignore back & forward slashes differences.
Ciao :-) |
Show » |
committed 1 file to 'Moodle CVS' - 10/Feb/09 02:30 AM
MDL-18195 installer - ignore differences in slashes when checking $CFG->dirroot
|
|
|
committed 2 files to 'Moodle CVS' - 10/Feb/09 02:46 AM
MDL-18195 installer - improve CFG->dirroot error message
|
|
|
committed 4 files to 'Lang CVS' - 11/Feb/09 03:32 AM
MDL-18083 Translated new strings for gradebook.
MDL-18195 Updated a translated string for debug based on lang/en_utf8 error message improvement.
|
|
|
martignoni committed 1 file to 'Lang CVS' - 11/Feb/09 04:23 AM
committed 1 file to 'Moodle CVS' - 12/Feb/09 02:00 AM
MDL-18195 installer - always suggest/write paths using forward slashes
|
|
|
|