Issue Details (XML | Word | Printable)

Key: MDL-18195
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Eloy Lafuente (stronk7)
Reporter: Eloy Lafuente (stronk7)
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-17458

Slashes normalization in installer

Created: 10/Feb/09 12:36 AM   Updated: 12/Feb/09 02:02 AM
Return to search
Component/s: Installation
Affects Version/s: 2.0
Fix Version/s: 2.0

Database: Any
Participants: Eloy Lafuente (stronk7) and Petr Skoda
Security Level: None
QA Assignee: Petr Skoda
Resolved date: 12/Feb/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
When working in the Windows installer, I've detected that threre are some problems with back & forward slashes in the installer:

dirroot is calculated with dirname() that uses "native" windows backslashes.
dataroot is calculated with moodle stuff, that always use forwardslashes

Later, dirroot is written with forwardslashes.

And then, later, in admin/index.php, dirroot is checked again with realpath(), and that doesn't pass the test when comparing back & forward slashed dirroots.

So I'm going to:

0) After chat with Sam, use always forward-slashes seems to be ok.
1) Change install to suggest forward-slashed dirroot.
2) Change admin/index.php check to ignore back & forward slashes differences.

Ciao :-)

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' - 10/Feb/09 02:30 AM
MDL-18195 installer - ignore differences in slashes when checking $CFG->dirroot
MODIFY admin/index.php   Rev. 1.376    (+3 -2 lines)
Eloy Lafuente (stronk7) committed 2 files to 'Moodle CVS' - 10/Feb/09 02:46 AM
MDL-18195 installer - improve CFG->dirroot error message
MODIFY admin/index.php   Rev. 1.377    (+2 -2 lines)
MODIFY lang/en_utf8/debug.php   Rev. 1.19    (+1 -1 lines)
Mitsuhiro Yoshida committed 4 files to 'Lang CVS' - 11/Feb/09 03:32 AM
MDL-18083 Translated new strings for gradebook.
MDL-18195 Updated a translated string for debug based on lang/en_utf8 error message improvement.
MODIFY ja_utf8/grades.php   Rev. 1.147    (+16 -3 lines)
MODIFY ja_utf8/debug.php   Rev. 1.19    (+1 -1 lines)
MODIFY ja_utf8/gradereport_grader.php   Rev. 1.3    (+2 -1 lines)
MODIFY ja_utf8/README   Rev. 1.940    (+1 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 11/Feb/09 04:23 AM
MDL-18195 String fixed
MODIFY fr_utf8/debug.php   Rev. 1.19    (+2 -2 lines)
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' - 12/Feb/09 02:00 AM
MDL-18195 installer - always suggest/write paths using forward slashes
MODIFY install.php   Rev. 1.128    (+6 -4 lines)