Issue Details (XML | Word | Printable)

Key: MDL-18208
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Sam Marshall
Reporter: Dan Poltawski
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Missing test for xsl extension?

Created: 11/Feb/09 09:07 AM   Updated: 17/Feb/09 11:41 PM
Component/s: Database SQL/XMLDB
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Dan Poltawski, Eloy Lafuente (stronk7) and Sam Marshall
Security Level: None
QA Assignee: Eloy Lafuente (stronk7)
Resolved date: 17/Feb/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
In the docs generator. We might want to warn about it on the page rather than making it a requirement.

Fatal error: Class 'XSLTProcessor' not found in /var/www/moodle/moodle/admin/xmldb/actions/generate_documentation/generate_documentation.class.php on line 79



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) added a comment - 17/Feb/09 03:56 AM
Adding Sam here... +1. If you are with other things, I can do that, Sam (you decide). Ciao

Sam Marshall added a comment - 17/Feb/09 09:55 PM
OK - I made it check the class exists just before trying to do the XSL. If the class doesn't exist it displays an error that tells you you need the xsl extension.

I think this is better than just hiding the doc links if you don't have the extension, because that could cause confusion. [I.e. user A tells B they should use the doc links, B says they don't see any links, A has no idea why.] At least this way it's clear what is going on.


Eloy Lafuente (stronk7) added a comment - 17/Feb/09 11:41 PM
Closing. Thanks!