Moodle

Missing test for xsl extension?

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Database SQL/XMLDB
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

In the docs generator. We might want to warn about it on the page rather than making it a requirement.

Fatal error: Class 'XSLTProcessor' not found in /var/www/moodle/moodle/admin/xmldb/actions/generate_documentation/generate_documentation.class.php on line 79

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Adding Sam here... +1. If you are with other things, I can do that, Sam (you decide). Ciao

Show
Eloy Lafuente (stronk7) added a comment - Adding Sam here... +1. If you are with other things, I can do that, Sam (you decide). Ciao
Hide
Permalink
Sam Marshall added a comment -

OK - I made it check the class exists just before trying to do the XSL. If the class doesn't exist it displays an error that tells you you need the xsl extension.

I think this is better than just hiding the doc links if you don't have the extension, because that could cause confusion. [I.e. user A tells B they should use the doc links, B says they don't see any links, A has no idea why.] At least this way it's clear what is going on.

Show
Sam Marshall added a comment - OK - I made it check the class exists just before trying to do the XSL. If the class doesn't exist it displays an error that tells you you need the xsl extension. I think this is better than just hiding the doc links if you don't have the extension, because that could cause confusion. [I.e. user A tells B they should use the doc links, B says they don't see any links, A has no idea why.] At least this way it's clear what is going on.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Closing. Thanks!

Show
Eloy Lafuente (stronk7) added a comment - Closing. Thanks!

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.