[#MDL-18223] Convert spamcleaner.php into an admin report for 1.9.5, 1.8.9 etc

Issue Details (XML | Word | Printable)

Key:	MDL-18223
Type:	Sub-task
Status:	Closed
Resolution:	Fixed
Priority:	Critical
Assignee:	Dongsheng Cai
Reporter:	Martin Dougiamas
Votes:	1
Watchers:	3

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-17107

Convert spamcleaner.php into an admin report for 1.9.5, 1.8.9 etc

Created: 12/Feb/09 04:31 PM Updated: 27/Sep/09 03:48 AM

Return to search

Component/s:

Administration

Affects Version/s:

1.6.9, 1.7.7, 1.8.8, 1.9.4

Fix Version/s:

1.6.9+, 1.7.7+, 1.8.9, 1.9.5, 2.0

Issue Links:

Relates

This issue has a non-specific relationship to:

~~MDL-17144~~ Implement spamcleaner.php tool to clean up damaged profiles

Participants:	David Mudrak, Dongsheng Cai, Martin Dougiamas and Petr Skoda
Security Level:	None
QA Assignee:	David Mudrak
Resolved date:	26/Feb/09
Affected Branches:	MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches:	MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

Description

« Hide

Dongsheng, can you turn spamcleaner.php (~~MDL-17144~~) into an admin report and backport it all the way back to 1.6?

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 17/Feb/09 04:29 PM

The one for 1.9.5 is look good, Dongsheng! Now we just need 1.8, 1.7 and 1.6 versions!

[ Permalink | « Hide ]

Petr Skoda added a comment - 17/Feb/09 04:37 PM

loops like this was not merged into HEAD, right?

[ Permalink | « Hide ]

Petr Skoda added a comment - 18/Feb/09 07:34 AM

merging to HEAD now and fixing problems in 1.9.x and HEAD...

[ Permalink | « Hide ]

Petr Skoda added a comment - 18/Feb/09 07:42 AM

merged into HEAD, fixed old report title in admin tree, normalised external page name

[ Permalink | « Hide ]

Petr Skoda added a comment - 18/Feb/09 07:45 AM

Fixed theoretical XSS - title attributes must be processed with s()

[ Permalink | « Hide ]

Petr Skoda added a comment - 18/Feb/09 07:57 AM

fixed some xhtml strict problems too

[ Permalink | « Hide ]

Petr Skoda added a comment - 18/Feb/09 08:03 AM

fixed repeated format_text() - should be used only once

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 23/Feb/09 03:17 PM

Backported to 1.8, 1,7 and 1.6.
In Moodle 1.6, yui is not supported internally, so I have to modify js code to run without yui.

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 26/Feb/09 10:23 AM

Thanks for testing.

[ Permalink | « Hide ]

David Mudrak added a comment - 03/Mar/09 09:05 PM

Works pretty well under 1.9 and 1.8. I haven't tested under 1.7 and 1.6. The report helped me to find a dozen of spam profiles at a site with 10k users. I had an issue with the report page layout and non-working Ignore/Delete buttons but I suppose that was because of non-valid HTML in the spam profiles. Maybe we can force HTML purifying of the profile description?

A note (haven't tested): CSS definition can be included inline in the profile. A spammer could, in theory, write a CSS so the profile content does not display at the report page, or is replaced by a look-like-a-valid profile. Any ideas regarding this?

IMO can be closed as the script seems to be successfully implemented as an admin report. Thanks for your work on this!

[ Permalink | « Hide ]

David Mudrak added a comment - 27/Sep/09 03:48 AM

Closing.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.