Moodle

Hardcoded style for TeX img breaks ability to decorate formulas by border

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.4
  • Fix Version/s: 1.9.5
  • Component/s: Filters
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Typical TeX formula:
<img style="border: 0px none ; vertical-align: middle;" src="http://www.cdp.tsure.ru/moodle/filter/tex/pix.php/32f5240d0dbf2ccbe75ef7f8ef2015e0.gif" alt="x^2" title="x^2" class="texrender"/>

I suggest move "border: 0px none" form style to class "texrender" in css files of standard theme.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Assigning to Donghseng. Agree. inline styles should be out completely.

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Donghseng. Agree. inline styles should be out completely.
Hide
Permalink
Dongsheng Cai added a comment -

Fixed, border is moved to css file.
But we cannot completely remove inline styles, because we need to define height, width and vertical-aligh in this case.

Show
Dongsheng Cai added a comment - Fixed, border is moved to css file. But we cannot completely remove inline styles, because we need to define height, width and vertical-aligh in this case.
Hide
Permalink
Dongsheng Cai added a comment -

Fixed, feel free to reopen it.

Show
Dongsheng Cai added a comment - Fixed, feel free to reopen it.
Hide
Permalink
Dongsheng Cai added a comment -

shoud add style property when use height and width

Show
Dongsheng Cai added a comment - shoud add style property when use height and width
Hide
Permalink
Tim Hunt added a comment -

Revised fix committed.

Show
Tim Hunt added a comment - Revised fix committed.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.