Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.7.7, 1.8.8, 1.9.4
-
Component/s: Database SQL/XMLDB
-
Labels:None
-
Environment:RedHat Linux, Apache 2.2.3, PHP 5.2.8, SQL Server
-
Database:Microsoft SQL
-
Difficulty:Easy
-
Affected Branches:MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
-
Fixed Branches:MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
Description
The data_filter() function in mod/data/filter.php has a SQL query that compares a text (or, in MSSQL, an ntext) column in a WHERE clause. MSSQL doesn't allow ntext columns in a WHERE clause, so the SQL statement throws errors.
Attachments
Issue Links
| This issue is duplicated by: | ||||
| MDL-16961 | mod/data/filter.php: text data not quoted in Data autolinking filter |
|
|
|
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Hide
Eloy Lafuente (stronk7)
added a comment -
Hi,
resolving as fixed. I've used the cross-db sql_compare_text() function to produce the SQL needed by each DB:
"AND " . sql_compare_text('df.param1', 1) . " = '1'";
Thanks for the report, Lucian! Ciao 
Show
Eloy Lafuente (stronk7)
added a comment - Hi,
resolving as fixed. I've used the cross-db sql_compare_text() function to produce the SQL needed by each DB:
"AND " . sql_compare_text('df.param1', 1) . " = '1'";
Thanks for the report, Lucian! Ciao
Here is a patch file for changes I made to mod/data/filter.php to resolve the issue.