Moodle

Messages Block - Sender's name/image does not link to sender's profile

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.4
  • Fix Version/s: 1.9.5
  • Component/s: Blocks, Chat, Messages
  • Labels:
    None
  • Environment:
    Any, IIS 6.0, W2K3
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

I've included a picture of the block where the problem exists. The mouse is hovered over "Admin Moodle" and the link shows up in the status bar of the window.

Steps to reproduce:
1. Put a 'Messages' block on the My Moodle page
2. A user sends a message to another user.
3. The recipient visits their My Moodle page and sees the sender's name and the number of unread messages.
4. Clicking on the sender's name / image sends the recipient to a (usually obscure or unavailable) course page instead of the sender's profile page.
5. Clicking on the number of messages opens the chat dialogue and shows the message (this is good).

Issue Links

This issue has a clone:
MDL-8162 Message Module - When receiving a message, the link to the person is a link to a course not even related to that person. I think the link should be to their profile. Minor Closed
This issue duplicates:
MDL-5887 No such course id Major Closed
MDL-6890 Name in the message block send the user to wrong error message Major Closed
This issue is duplicated by:
MDL-5887 No such course id Major Closed
MDL-6890 Name in the message block send the user to wrong error message Major Closed
MDL-8162 Message Module - When receiving a message, the link to the person is a link to a course not even related to that person. I think the link should be to their profile. Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Minh-Tam Nguyen added a comment -

We just ran across this one as well, on 1.9.4

It seems to me that these three issues are about the same problem:
MDL-6890 - Name in the message block send the user to wrong error message
MDL-5887 - No such course id
MDL-18279 - Messages Block - Sender's name/image does not link to sender's profile

Cheers,
Minh-Tam

Show
Minh-Tam Nguyen added a comment - We just ran across this one as well, on 1.9.4 It seems to me that these three issues are about the same problem: MDL-6890 - Name in the message block send the user to wrong error message MDL-5887 - No such course id MDL-18279 - Messages Block - Sender's name/image does not link to sender's profile Cheers, Minh-Tam
Hide
Permalink
Dan Poltawski added a comment -

Thanks for the links Minh-Tam. I think really the link should be consistent with the messages block and link to the site profile and not in individual courses (this would break if the user who messaged was not enrolled in the current course anyway). So i'm about to commit a fix to this to use SITEID.

Show
Dan Poltawski added a comment - Thanks for the links Minh-Tam. I think really the link should be consistent with the messages block and link to the site profile and not in individual courses (this would break if the user who messaged was not enrolled in the current course anyway). So i'm about to commit a fix to this to use SITEID.
Hide
Permalink
Dan Poltawski added a comment -

Thanks for the report. I've fixed this in CVS by instead linking to the site profile, which I think is the most robust solution.

Show
Dan Poltawski added a comment - Thanks for the report. I've fixed this in CVS by instead linking to the site profile, which I think is the most robust solution.
Hide
Permalink
Minh-Tam Nguyen added a comment -

Hello Dan, Thanks for the fix.
will this now always link to /user/view.php?id=*&course=1, no matter where the block is located, or will behave differently depending on whether the block is on myMoodle or in a course?
Cheers,
Minh-Tam

Show
Minh-Tam Nguyen added a comment - Hello Dan, Thanks for the fix. will this now always link to /user/view.php?id=*&course=1, no matter where the block is located, or will behave differently depending on whether the block is on myMoodle or in a course? Cheers, Minh-Tam
Hide
Permalink
Dan Poltawski added a comment -

Minh-Tam, It will link to site course (which usually is course=1) no matter where the block is located.

I think this is the most robust solution as often the user who the message was received from might not be a member of the course the user is in when they used the block.

Show
Dan Poltawski added a comment - Minh-Tam, It will link to site course (which usually is course=1) no matter where the block is located. I think this is the most robust solution as often the user who the message was received from might not be a member of the course the user is in when they used the block.
Hide
Permalink
Jerome Mouneyrac added a comment -

It works. Thanks Barry for the report, Minh-Tam for your comment and Dan for the fix.

Show
Jerome Mouneyrac added a comment - It works. Thanks Barry for the report, Minh-Tam for your comment and Dan for the fix.

People

Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.