Moodle

Regrading quiz alter last acces quiz date on Outline report

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.4
  • Fix Version/s: 1.9.5
  • Component/s: Quiz
  • Labels:
    None
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

When trying to regrade quiz attemtp, User's Outline Report shows the regrade date rather than teh last quiz attempt date.

To reproduce:
1. create a quiz in a coirse and allow student to attempt it
2. now close the quiz (not sure ithis step is significant)
3. access a user's Outline Report. The date shown is correctly the last access to the Quiz
4. access Quiz result and regrade quizzes
5. access again the user's Outline Report. The date shown for the Quiz is now the date of the regrade
6. access the very same user's Complete report. Date shown here are correct, so there is a discrepancy among the two report.

Possible solutions (thanks to Eloy):
1) Make the "regrade" not to modify dates.
2) Make the report to use the attempt grade (like the complete report does)

My +1 for the second option.

  1. MDL-18285.patch.txt
    17/Feb/09 7:35 PM
    0.6 kB
    Eloy Lafuente (stronk7)
  2. quizusersummary.patch.txt
    18/Feb/09 3:30 PM
    4 kB
    Tim Hunt

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Adding simple patch that fixes the inconsistency retrieving the max attempt time (note it could be done in one query but for readability it should be ok in that report to perform 1-more-query).

Show
Eloy Lafuente (stronk7) added a comment - Adding simple patch that fixes the inconsistency retrieving the max attempt time (note it could be done in one query but for readability it should be ok in that report to perform 1-more-query).
Hide
Eloy Lafuente (stronk7) added a comment -

Assigning to Tim for his consideration and addressing to 1.9.5. Thanks Andrea.

Show
Eloy Lafuente (stronk7) added a comment - Assigning to Tim for his consideration and addressing to 1.9.5. Thanks Andrea.
Hide
Tim Hunt added a comment -

Thanks for the clear bug report. I'll look into it.

Show
Tim Hunt added a comment - Thanks for the clear bug report. I'll look into it.
Hide
Tim Hunt added a comment -

The field in the quiz_grades table that is being displayed is called 'timemodified'. So I think it is reasonable that the quiz_save_best_grade (which is used be regrade, and elsewhere) changes that.

So yes, I vote for Possible solution 2) too.

Attached (quizusersummary.patch.txt) is a slightly improved patch that reuses an existing function. Comments?

Show
Tim Hunt added a comment - The field in the quiz_grades table that is being displayed is called 'timemodified'. So I think it is reasonable that the quiz_save_best_grade (which is used be regrade, and elsewhere) changes that. So yes, I vote for Possible solution 2) too. Attached (quizusersummary.patch.txt) is a slightly improved patch that reuses an existing function. Comments?
Hide
Tim Hunt added a comment -

So, the last thing that happened here is that I posted a patch and asked for comments. Since then, I have heard nothing, so the patch remains uncommitted.

Anyway, I will probably commit this tomorrow, once the testing day moratorium is over, if I remember.

Show
Tim Hunt added a comment - So, the last thing that happened here is that I posted a patch and asked for comments. Since then, I have heard nothing, so the patch remains uncommitted. Anyway, I will probably commit this tomorrow, once the testing day moratorium is over, if I remember.
Hide
Tim Hunt added a comment -

Done. Please test.

Show
Tim Hunt added a comment - Done. Please test.
Hide
Sam Hemelryk added a comment -

Tested and all works well. Thanks Tim

Show
Sam Hemelryk added a comment - Tested and all works well. Thanks Tim
Hide
Matt Clarkson added a comment -

Note: This bug has been reintroduced by the this commit: 5e150ff30f9a71a4a3edf8358ec976e12e4dd281

Show
Matt Clarkson added a comment - Note: This bug has been reintroduced by the this commit: 5e150ff30f9a71a4a3edf8358ec976e12e4dd281
Hide
Tim Hunt added a comment -

This bug is ancient history. Please could you create a new issue for this. Thanks.

Show
Tim Hunt added a comment - This bug is ancient history. Please could you create a new issue for this. Thanks.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: