Issue Details (XML | Word | Printable)

Key: MDL-18293
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14679

do not check return value from isert_record and update_record and cleanup unused error messages replaced by new DML exceptions

Created: 18/Feb/09 01:32 AM   Updated: 14/Jun/09 02:34 AM
Return to search
Component/s: Database SQL/XMLDB
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Petr Skoda
Security Level: None
Resolved date: 14/Jun/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda committed 10 files to 'Moodle CVS' - 18/Feb/09 01:33 AM
MDL-18293 removing unused error strings (now replaced by exceptions)
MODIFY course/modedit.php   Rev. 1.61    (+2 -4 lines)
MODIFY course/lib.php   Rev. 1.641    (+5 -14 lines)
MODIFY course/index.php   Rev. 1.110    (+4 -10 lines)
MODIFY mod/glossary/Attic/comment.php   Rev. 1.49    (+4 -6 lines)
MODIFY mod/hotpot/lib.php   Rev. 1.110    (+2 -4 lines)
MODIFY course/mod.php   Rev. 1.138    (+2 -4 lines)
MODIFY mod/glossary/editcategories.php   Rev. 1.47    (+4 -7 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.167    (+1 -8 lines)
MODIFY user/profile/definelib.php   Rev. 1.19    (+5 -13 lines)
MODIFY course/editcategory.php   Rev. 1.22    (+1 -3 lines)
Mitsuhiro Yoshida committed 3 files to 'Lang CVS' - 18/Feb/09 01:39 AM
MDL-18293 removing unused error strings based on lang/en_utf8 removal.
MDL-18208 Translated a new string for xmldb.
MODIFY ja_utf8/README   Rev. 1.947    (+1 -1 lines)
MODIFY ja_utf8/xmldb.php   Rev. 1.24    (+2 -1 lines)
MODIFY ja_utf8/error.php   Rev. 1.123    (+8 -8 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 18/Feb/09 01:44 AM
MDL-18293 exception cleanup
MODIFY group/lib.php   Rev. 1.20    (+46 -58 lines)
Petr Skoda committed 8 files to 'Moodle CVS' - 18/Feb/09 01:50 AM
MDL-18293 exception and DML cleanup
MODIFY lib/moodlelib.php   Rev. 1.1171    (+20 -20 lines)
MODIFY group/grouping.php   Rev. 1.22    (+3 -7 lines)
MODIFY admin/auth_config.php   Rev. 1.25    (+1 -3 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.168    (+1 -2 lines)
MODIFY group/autogroup.php   Rev. 1.10    (+3 -10 lines)
MODIFY group/group.php   Rev. 1.24    (+2 -6 lines)
MODIFY group/delete.php   Rev. 1.3    (+1 -3 lines)
MODIFY group/overview.php   Rev. 1.8    (+3 -7 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 18/Feb/09 02:15 AM
MDL-18293 exception and DML cleanup
MODIFY lib/datalib.php   Rev. 1.499    (+4 -10 lines)
Petr Skoda committed 4 files to 'Moodle CVS' - 18/Feb/09 02:23 AM
MDL-18293 exception and DML cleanup
MODIFY admin/index.php   Rev. 1.379    (+2 -4 lines)
MODIFY admin/Attic/cliupgrade.php   Rev. 1.39    (+1 -3 lines)
MODIFY lib/moodlelib.php   Rev. 1.1172    (+42 -44 lines)
MODIFY enrol/manual/enrol.php   Rev. 1.44    (+3 -8 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 18/Feb/09 02:32 AM
MDL-18293 exception and DML cleanup
MODIFY lib/moodlelib.php   Rev. 1.1173    (+47 -49 lines)
martignoni committed 1 file to 'Lang CVS' - 01/Mar/09 09:20 PM
MDL-18293, comment added for obsolete 2.0 strings
MODIFY fr_utf8/error.php   Rev. 1.170    (+10 -10 lines)
martignoni committed 1 file to 'Lang CVS' - 01/Mar/09 09:21 PM
MDL-18293, comment added for obsolete string
MODIFY fr_utf8/error.php   Rev. 1.171    (+2 -2 lines)
Petr Skoda committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 04/Jun/09 03:59 AM
MDL-18293 fixing missing error string
MODIFY mod/forum/rate_ajax.php   Rev. 1.1.2.3    (+2 -2 lines)
Petr Skoda committed 14 files to 'Moodle CVS' - 04/Jun/09 04:00 AM
MDL-18293 $DB->somethiong is using exceptions, no need for ifs tehre, removing useless strings
MODIFY lib/questionlib.php   Rev. 1.195    (+1 -3 lines)
MODIFY user/profile/lib.php   Rev. 1.43    (+2 -4 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.187    (+1 -15 lines)
MODIFY lib/simpletest/Attic/testfilelib.php   Rev. 1.11    (+2 -4 lines)
MODIFY user/profile/definelib.php   Rev. 1.20    (+2 -4 lines)
MODIFY mod/data/rate.php   Rev. 1.17    (+2 -4 lines)
MODIFY question/format.php   Rev. 1.52    (+2 -4 lines)
MODIFY course/editcategory.php   Rev. 1.24    (+1 -3 lines)
MODIFY mod/scorm/lib.php   Rev. 1.117    (+1 -3 lines)
MODIFY course/modedit.php   Rev. 1.69    (+4 -10 lines)
MODIFY user/edit.php   Rev. 1.187    (+2 -4 lines)
MODIFY lib/accesslib.php   Rev. 1.597    (+2 -5 lines)
MODIFY mod/forum/rate.php   Rev. 1.33    (+2 -4 lines)
MODIFY mod/hotpot/lib.php   Rev. 1.117    (+1 -3 lines)
Petr Skoda committed 9 files to 'Moodle CVS' - 04/Jun/09 04:16 AM
MDL-18293 $DB->somethiong is using exceptions, no need for ifs there, removing useless strings
MODIFY mod/forum/post.php   Rev. 1.193    (+2 -4 lines)
MODIFY lib/datalib.php   Rev. 1.503    (+1 -3 lines)
MODIFY mod/forum/lib.php   Rev. 1.791    (+3 -11 lines)
MODIFY course/request.php   Rev. 1.22    (+2 -4 lines)
MODIFY lang/en_utf8/forum.php   Rev. 1.58    (+1 -4 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.188    (+1 -3 lines)
MODIFY lib/questionlib.php   Rev. 1.196    (+1 -3 lines)
MODIFY course/index.php   Rev. 1.115    (+2 -4 lines)
MODIFY lib/moodlelib.php   Rev. 1.1212    (+1 -5 lines)
Petr Skoda committed 14 files to 'Moodle CVS' - 04/Jun/09 04:25 AM
MDL-18293 $DB->something is using exceptions, no need for ifs there, removing useless strings
MODIFY mod/feedback/lib.php   Rev. 1.36    (+2 -6 lines)
MODIFY mod/data/field/picture/field.class.php   Rev. 1.32    (+2 -4 lines)
MODIFY lang/en_utf8/feedback.php   Rev. 1.10    (+1 -3 lines)
MODIFY mod/data/field/file/field.class.php   Rev. 1.32    (+2 -4 lines)
MODIFY mod/chat/gui_header_js/users.php   Rev. 1.23    (+3 -5 lines)
MODIFY lang/en_utf8/assignment.php   Rev. 1.31    (+1 -2 lines)
MODIFY lang/en_utf8/choice.php   Rev. 1.14    (+1 -3 lines)
MODIFY mod/chat/gui_header_js/insert.php   Rev. 1.18    (+3 -4 lines)
MODIFY lang/en_utf8/chat.php   Rev. 1.17    (+1 -2 lines)
MODIFY mod/chat/gui_basic/index.php   Rev. 1.12    (+3 -4 lines)
MODIFY mod/choice/lib.php   Rev. 1.104    (+2 -6 lines)
MODIFY lang/en_utf8/data.php   Rev. 1.81    (+1 -2 lines)
MODIFY mod/chat/lib.php   Rev. 1.143    (+4 -9 lines)
MODIFY mod/assignment/lib.php   Rev. 1.385    (+1 -3 lines)
Petr Skoda committed 8 files to 'Moodle CVS' - 04/Jun/09 04:37 AM
MDL-18293 $DB->something is using exceptions, no need for ifs there, removing useless strings
MODIFY lib/grade/grade_object.php   Rev. 1.47    (+3 -8 lines)
MODIFY user/emailupdate.php   Rev. 1.6    (+6 -9 lines)
MODIFY lang/en_utf8/blog.php   Rev. 1.28    (+1 -2 lines)
MODIFY user/editadvanced.php   Rev. 1.48    (+3 -7 lines)
MODIFY lib/grade/grade_outcome.php   Rev. 1.32    (+2 -2 lines)
MODIFY blog/edit.php   Rev. 1.70    (+13 -26 lines)
MODIFY mod/glossary/lib.php   Rev. 1.251    (+7 -9 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.189    (+1 -2 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 14/Jun/09 12:47 AM
MDL-18293 removed obsoleted checking of return values from insert and update_record
MODIFY lib/file/file_storage.php   Rev. 1.32    (+1 -4 lines)
Petr Skoda committed 26 files to 'Moodle CVS' - 14/Jun/09 01:17 AM
MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup
MODIFY question/contextmove.php   Rev. 1.13    (+3 -7 lines)
MODIFY question/category_class.php   Rev. 1.53    (+7 -14 lines)
MODIFY question/type/calculated/questiontype.php   Rev. 1.61    (+17 -50 lines)
MODIFY lib/accesslib.php   Rev. 1.598    (+1 -3 lines)
MODIFY question/type/truefalse/questiontype.php   Rev. 1.27    (+7 -25 lines)
MODIFY lang/en_utf8/wiki.php   Rev. 1.9    (+1 -3 lines)
MODIFY lib/questionlib.php   Rev. 1.198    (+2 -6 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.190    (+1 -2 lines)
MODIFY question/type/match/questiontype.php   Rev. 1.53    (+7 -24 lines)
MODIFY course/rest.php   Rev. 1.16    (+2 -5 lines)
MODIFY question/type/multichoice/questiontype.php   Rev. 1.46    (+8 -26 lines)
MODIFY mod/wiki/overridelock.php   Rev. 1.6    (+1 -3 lines)
MODIFY question/format.php   Rev. 1.53    (+2 -4 lines)
MODIFY question/type/randomsamatch/questiontype.php   Rev. 1.13    (+3 -9 lines)
MODIFY question/type/shortanswer/questiontype.php   Rev. 1.44    (+3 -9 lines)
MODIFY lang/en_utf8/question.php   Rev. 1.36    (+1 -17 lines)
MODIFY question/type/essay/questiontype.php   Rev. 1.32    (+3 -9 lines)
MODIFY backup/restorelib.php   Rev. 1.386    (+3 -7 lines)
MODIFY question/restorelib.php   Rev. 1.42    (+3 -7 lines)
MODIFY blocks/rss_client/Attic/block_rss_client_action.php   Rev. 1.66    (+4 -8 lines)
MODIFY question/type/calculatedsimple/questiontype.php   Rev. 1.4    (+8 -18 lines)
MODIFY question/type/questiontype.php   Rev. 1.127    (+6 -16 lines)
MODIFY enrol/authorize/authorizenet.class.php   Rev. 2.6    (+2 -4 lines)
MODIFY course/lib.php   Rev. 1.659    (+3 -7 lines)
MODIFY question/type/multianswer/questiontype.php   Rev. 1.74    (+3 -10 lines)
MODIFY mod/wiki/lib.php   Rev. 1.67    (+3 -9 lines)
Petr Skoda committed 15 files to 'Moodle CVS' - 14/Jun/09 01:35 AM
MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup
MODIFY blocks/rss_client/Attic/block_rss_client_action.php   Rev. 1.67    (+2 -5 lines)
MODIFY mod/feedback/lib.php   Rev. 1.38    (+1 -3 lines)
MODIFY mod/glossary/import.php   Rev. 1.50    (+4 -13 lines)
MODIFY mod/forum/lib.php   Rev. 1.793    (+3 -9 lines)
MODIFY mod/assignment/lib.php   Rev. 1.386    (+3 -9 lines)
MODIFY mod/assignment/type/online/assignment.class.php   Rev. 1.68    (+2 -4 lines)
MODIFY mod/data/field/picture/field.class.php   Rev. 1.33    (+2 -5 lines)
MODIFY mod/forum/post.php   Rev. 1.194    (+2 -4 lines)
MODIFY mod/data/field.php   Rev. 1.32    (+4 -9 lines)
MODIFY lang/en_utf8/data.php   Rev. 1.82    (+1 -2 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.191    (+1 -2 lines)
MODIFY lang/en_utf8/forum.php   Rev. 1.59    (+1 -2 lines)
MODIFY mod/glossary/exportentry.php   Rev. 1.37    (+2 -4 lines)
MODIFY lang/en_utf8/glossary.php   Rev. 1.23    (+1 -2 lines)
MODIFY mod/data/lib.php   Rev. 1.229    (+3 -9 lines)
Petr Skoda committed 21 files to 'Moodle CVS' - 14/Jun/09 01:47 AM
MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup
MODIFY lang/en_utf8/resource.php   Rev. 1.19    (+1 -2 lines)
MODIFY mod/scorm/lib.php   Rev. 1.118    (+1 -3 lines)
MODIFY lang/en_utf8/lesson.php   Rev. 1.46    (+1 -2 lines)
MODIFY mod/data/import.php   Rev. 1.34    (+2 -4 lines)
MODIFY login/forgot_password.php   Rev. 1.55    (+3 -7 lines)
MODIFY mod/lesson/locallib.php   Rev. 1.82    (+6 -18 lines)
MODIFY mod/hotpot/index.php   Rev. 1.40    (+2 -4 lines)
MODIFY mod/quiz/locallib.php   Rev. 1.178    (+3 -9 lines)
MODIFY mod/resource/lib.php   Rev. 1.117    (+1 -3 lines)
MODIFY mod/hotpot/lib.php   Rev. 1.118    (+2 -3 lines)
MODIFY lang/en_utf8/hotpot.php   Rev. 1.17    (+1 -2 lines)
MODIFY mod/glossary/import.php   Rev. 1.51    (+3 -7 lines)
MODIFY mod/hotpot/attempt.php   Rev. 1.25    (+2 -4 lines)
MODIFY mod/quiz/processattempt.php   Rev. 1.7    (+3 -7 lines)
MODIFY mod/forum/lib.php   Rev. 1.794    (+1 -3 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.192    (+1 -3 lines)
MODIFY mod/chat/lib.php   Rev. 1.144    (+3 -6 lines)
MODIFY auth/mnet/auth.php   Rev. 1.56    (+2 -7 lines)
MODIFY mod/lesson/essay.php   Rev. 1.20    (+8 -13 lines)
MODIFY mod/lesson/action/continue.php   Rev. 1.56    (+3 -5 lines)
MODIFY lang/en_utf8/forum.php   Rev. 1.60    (+1 -2 lines)
Petr Skoda committed 10 files to 'Moodle CVS' - 14/Jun/09 01:55 AM
MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup
MODIFY mod/data/lib.php   Rev. 1.230    (+1 -3 lines)
MODIFY question/type/calculated/questiontype.php   Rev. 1.62    (+6 -25 lines)
MODIFY question/type/numerical/questiontype.php   Rev. 1.34    (+6 -18 lines)
MODIFY question/type/calculatedsimple/questiontype.php   Rev. 1.5    (+5 -20 lines)
MODIFY mod/data/rate.php   Rev. 1.18    (+2 -4 lines)
MODIFY mod/assignment/type/offline/assignment.class.php   Rev. 1.16    (+2 -4 lines)
MODIFY mod/assignment/lib.php   Rev. 1.387    (+1 -3 lines)
MODIFY mod/glossary/rate.php   Rev. 1.20    (+3 -7 lines)
MODIFY enrol/authorize/authorizenet.class.php   Rev. 2.7    (+2 -4 lines)
MODIFY mod/forum/rate.php   Rev. 1.34    (+2 -4 lines)
Petr Skoda committed 7 files to 'Moodle CVS' - 14/Jun/09 02:04 AM
MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup
MODIFY mod/hotpot/attempt.php   Rev. 1.26    (+3 -11 lines)
MODIFY question/type/numerical/questiontype.php   Rev. 1.35    (+3 -6 lines)
MODIFY auth/mnet/auth.php   Rev. 1.57    (+5 -13 lines)
MODIFY lang/en_utf8/hotpot.php   Rev. 1.18    (+1 -2 lines)
MODIFY mod/data/import.php   Rev. 1.35    (+2 -4 lines)
MODIFY mod/data/restorelib.php   Rev. 1.34    (+2 -7 lines)
MODIFY mod/hotpot/view.php   Rev. 1.49    (+1 -4 lines)
Petr Skoda committed 20 files to 'Moodle CVS' - 14/Jun/09 02:16 AM
MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup
MODIFY mod/quiz/startattempt.php   Rev. 1.6    (+2 -4 lines)
MODIFY mod/data/lib.php   Rev. 1.231    (+2 -7 lines)
MODIFY mod/lesson/locallib.php   Rev. 1.83    (+8 -26 lines)
MODIFY course/format/weeks/format.php   Rev. 1.91    (+2 -4 lines)
MODIFY enrol/authorize/authorizenet.class.php   Rev. 2.8    (+2 -5 lines)
MODIFY mod/lesson/action/continue.php   Rev. 1.57    (+3 -5 lines)
MODIFY lib/moodlelib.php   Rev. 1.1214    (+1 -3 lines)
MODIFY backup/restorelib.php   Rev. 1.387    (+3 -8 lines)
MODIFY mod/scorm/lib.php   Rev. 1.119    (+1 -3 lines)
MODIFY lib/questionlib.php   Rev. 1.199    (+2 -8 lines)
MODIFY grade/import/csv/index.php   Rev. 1.47    (+2 -7 lines)
MODIFY mod/feedback/lib.php   Rev. 1.39    (+3 -9 lines)
MODIFY lib/accesslib.php   Rev. 1.599    (+3 -7 lines)
MODIFY mod/forum/post.php   Rev. 1.195    (+2 -4 lines)
MODIFY mod/lesson/lib.php   Rev. 1.66    (+1 -3 lines)
MODIFY course/format/topics/format.php   Rev. 1.98    (+2 -4 lines)
MODIFY mod/hotpot/lib.php   Rev. 1.119    (+3 -10 lines)
MODIFY mod/forum/lib.php   Rev. 1.795    (+5 -18 lines)
MODIFY admin/generator.php   Rev. 1.22    (+6 -12 lines)
MODIFY lang/en_utf8/hotpot.php   Rev. 1.19    (+1 -4 lines)
Petr Skoda committed 20 files to 'Moodle CVS' - 14/Jun/09 02:34 AM
MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup
MODIFY backup/restorelib.php   Rev. 1.388    (+6 -21 lines)
MODIFY mod/forum/lib.php   Rev. 1.796    (+1 -3 lines)
MODIFY course/lib.php   Rev. 1.660    (+2 -4 lines)
MODIFY grade/import/csv/index.php   Rev. 1.48    (+2 -8 lines)
MODIFY message/output/jabber/lib.php   Rev. 1.2    (+2 -4 lines)
MODIFY message/output/jabber/db/install.php   Rev. 1.2    (+1 -3 lines)
MODIFY enrol/paypal/ipn.php   Rev. 1.28    (+2 -4 lines)
MODIFY message/output/email/lib.php   Rev. 1.2    (+2 -4 lines)
MODIFY backup/lib.php   Rev. 1.124    (+2 -4 lines)
MODIFY question/type/questiontype.php   Rev. 1.128    (+2 -6 lines)
MODIFY message/output/email/db/install.php   Rev. 1.2    (+1 -3 lines)
MODIFY mod/quiz/lib.php   Rev. 1.339    (+1 -3 lines)
MODIFY grade/import/xml/lib.php   Rev. 1.10    (+2 -7 lines)
MODIFY message/output/popup/lib.php   Rev. 1.2    (+2 -4 lines)
MODIFY message/output/popup/message_output_popup.php   Rev. 1.7    (+2 -4 lines)
MODIFY mod/feedback/mapcourse.php   Rev. 1.9    (+4 -4 lines)
MODIFY mod/lesson/action/continue.php   Rev. 1.58    (+3 -5 lines)
MODIFY lib/questionlib.php   Rev. 1.200    (+1 -3 lines)
MODIFY message/output/popup/db/install.php   Rev. 1.2    (+1 -3 lines)
MODIFY mod/feedback/import.php   Rev. 1.8    (+3 -6 lines)
martignoni committed 1 file to 'Lang CVS' - 23/Jun/09 10:48 PM
MDL-18293 Added comment for obsolete strings
MODIFY fr_utf8/error.php   Rev. 1.192    (+15 -15 lines)
martignoni committed 2 files to 'Lang CVS' - 23/Jun/09 10:52 PM
MDL-18293 commented out obsolete strings
MODIFY fr_utf8/forum.php   Rev. 1.70    (+4 -4 lines)
MODIFY fr_utf8/error.php   Rev. 1.193    (+3 -3 lines)
martignoni committed 5 files to 'Lang CVS' - 26/Jun/09 02:41 AM
MDL-18293 Commented out obsolete strings
MODIFY fr_utf8/data.php   Rev. 1.83    (+2 -2 lines)
MODIFY fr_utf8/chat.php   Rev. 1.24    (+2 -2 lines)
MODIFY fr_utf8/feedback.php   Rev. 1.14    (+1 -3 lines)
MODIFY fr_utf8/choice.php   Rev. 1.14    (+3 -3 lines)
MODIFY fr_utf8/assignment.php   Rev. 1.48    (+2 -2 lines)
martignoni committed 2 files to 'Lang CVS' - 26/Jun/09 02:47 AM
MDL-18293 Commented out obsolete strings
MODIFY fr_utf8/error.php   Rev. 1.194    (+2 -2 lines)
MODIFY fr_utf8/blog.php   Rev. 1.32    (+2 -2 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators