[#MDL-18301] Hidden Quiz Grade not working

Issue Details (XML | Word | Printable)

Key:	MDL-18301
Type:	Bug
Status:	Open
Priority:	Critical
Assignee:	Petr Skoda
Reporter:	David Somers-Harris
Votes:	13
Watchers:	11

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Hidden Quiz Grade not working

Created: 18/Feb/09 04:43 PM Updated: 26/Oct/09 10:21 AM

Return to search

Component/s:

Gradebook, Quiz

Affects Version/s:

1.9.4

Fix Version/s:

1.9.7

File Attachments:

MDL-18301.patch (3 kB)
2.

MDL-18301_2.patch (1 kB)

Issue Links:

Cloners

This issue has a clone:

~~MDL-18114~~ Quiz results are not displayed in gradebook in certain circumstances

Dependency

This issue will help resolve:

MDL-15715 Grade item disappearing after student takes quiz

Relates

This issue has a non-specific relationship to:

MDL-13978 Problems in the quiz when the grade is locked in the gradebook

Database:	Any
URL:	http://demo.moodle.org/grade/edit/tree/item.php?courseid=5&id=38&gpr_type=report&gpr_plugin=grader&gpr_courseid=5
Participants:	David Somers-Harris, Helen Foster, Michael Blake, Nicolas Connault, Penny Leach and Petr Skoda
Security Level:	None
QA Assignee:	Helen Foster
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

When you attempt to hide the grades of a quiz, the "hidden" checkbox does not stay checked even after saving.

How to reproduce.

1. With a course which has a quiz, go to the gradebook
2. Turn editing on and click the edit button under the quiz to edit the quiz grade item.
3. Check the "Hidden" checkbox
4. Save changes
5. Click on the edit button again to verify whether the setting was actually saved or not.

You will see that it doesn't save. I reproduced this on our own installation as well as the demo.moodle.org installation.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Helen Foster added a comment - 05/Mar/09 11:02 PM

David, thanks for your report with clear steps of how to reproduce the problem.

I can confirm that it remains a problem in 1.9.4+.

Setting a fix version of 1.9.5 in the hope that it can be fixed soon.

[ Permalink | « Hide ]

Nicolas Connault added a comment - 06/Mar/09 12:04 AM

Just attached a proposed patch (MDL-18301.patch)

[ Permalink | « Hide ]

Nicolas Connault added a comment - 06/Mar/09 12:22 AM

Attached a differenty formatted version of the patch

[ Permalink | « Hide ]

Petr Skoda added a comment - 06/Mar/09 12:56 AM

I do not think this is a good long term solution for 2.0, the reason is we should be moving all grading related settings and functions into gradebook.

[ Permalink | « Hide ]

Penny Leach added a comment - 06/Mar/09 01:06 AM

We need to fix it in 1.9 as well as 2.0, Petr

[ Permalink | « Hide ]

Nicolas Connault added a comment - 06/Mar/09 04:27 PM - edited

Attached unified diff: MDL-18301.patch
CVS commit message: Preventing the quiz module from modifying its grade item's settings each time the gradebook attempts to change them (in essence, giving the gradebook priority over the grade item settings).

[ Permalink | « Hide ]

Nicolas Connault added a comment - 06/Mar/09 05:09 PM

From discussion in HQ chat:

timhunt: The trouble is Nico, it was designed to work that way for a reason. When you create a quiz and intentionally set the grades to be hidden from students, then it was a feature requested in the original gradebook spec that the grade item should automatically be hidden in the gradebook.

[ Permalink | « Hide ]

Nicolas Connault added a comment - 30/Apr/09 04:33 PM

then the hidden controls should be disabled in the gradebook, and a link to the quiz module form given. Currently it appears horridly buggy from the gradebook's point of view.

[ Permalink | « Hide ]

Michael Blake added a comment - 26/Oct/09 10:21 AM

Received a request from Moodle Partner (Miguel Santos @ Moodlerooms) to raise the priority on this. No activity for a few months. Nico, you state the feature looks horribly buggy - what's required to fix?

All content on this web site is made available under the GNU General Public License, unless otherwise stated.