Moodle

Hidden Quiz Grade not working

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: 1.9.4, 2.0
  • Fix Version/s: STABLE backlog
  • Component/s: Gradebook, Quiz
  • Labels:

Description

When you attempt to hide the grades of a quiz, the "hidden" checkbox does not stay checked even after saving.

How to reproduce.

1. With a course which has a quiz, go to the gradebook
2. Turn editing on and click the edit button under the quiz to edit the quiz grade item.
3. Check the "Hidden" checkbox
4. Save changes
5. Click on the edit button again to verify whether the setting was actually saved or not.

You will see that it doesn't save. I reproduced this on our own installation as well as the demo.moodle.org installation.

Attachments

  1. Text File
    MDL-18301_2.patch
    06/Mar/09 12:31 AM
    1 kB
    Nicolas Connault
  2. Text File
    MDL-18301.patch
    06/Mar/09 4:27 PM
    3 kB
    Nicolas Connault

Issue Links

This issue has a clone:
MDL-18114 Quiz results are not displayed in gradebook in certain circumstances Minor Closed
This issue will help resolve:
MDL-15715 Grade item disappearing after student takes quiz Major Closed
This issue has a non-specific relationship to:
MDL-13978 Problems in the quiz when the grade is locked in the gradebook Major Reopened

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Helen Foster added a comment -

David, thanks for your report with clear steps of how to reproduce the problem.

I can confirm that it remains a problem in 1.9.4+.

Setting a fix version of 1.9.5 in the hope that it can be fixed soon.

Show
Helen Foster added a comment - David, thanks for your report with clear steps of how to reproduce the problem. I can confirm that it remains a problem in 1.9.4+. Setting a fix version of 1.9.5 in the hope that it can be fixed soon.
Hide
Permalink
Nicolas Connault added a comment -

Just attached a proposed patch (MDL-18301.patch)

Show
Nicolas Connault added a comment - Just attached a proposed patch (MDL-18301.patch)
Hide
Permalink
Nicolas Connault added a comment -

Attached a differenty formatted version of the patch

Show
Nicolas Connault added a comment - Attached a differenty formatted version of the patch
Hide
Permalink
Petr Škoda (skodak) added a comment -

I do not think this is a good long term solution for 2.0, the reason is we should be moving all grading related settings and functions into gradebook.

Show
Petr Škoda (skodak) added a comment - I do not think this is a good long term solution for 2.0, the reason is we should be moving all grading related settings and functions into gradebook.
Hide
Permalink
Penny Leach added a comment -

We need to fix it in 1.9 as well as 2.0, Petr

Show
Penny Leach added a comment - We need to fix it in 1.9 as well as 2.0, Petr
Hide
Permalink
Nicolas Connault added a comment - - edited

Attached unified diff: MDL-18301.patch
CVS commit message: Preventing the quiz module from modifying its grade item's settings each time the gradebook attempts to change them (in essence, giving the gradebook priority over the grade item settings).

Show
Nicolas Connault added a comment - - edited Attached unified diff: MDL-18301.patch CVS commit message: Preventing the quiz module from modifying its grade item's settings each time the gradebook attempts to change them (in essence, giving the gradebook priority over the grade item settings).
Hide
Permalink
Nicolas Connault added a comment -

From discussion in HQ chat:

timhunt: The trouble is Nico, it was designed to work that way for a reason. When you create a quiz and intentionally set the grades to be hidden from students, then it was a feature requested in the original gradebook spec that the grade item should automatically be hidden in the gradebook.

Show
Nicolas Connault added a comment - From discussion in HQ chat: timhunt: The trouble is Nico, it was designed to work that way for a reason. When you create a quiz and intentionally set the grades to be hidden from students, then it was a feature requested in the original gradebook spec that the grade item should automatically be hidden in the gradebook.
Hide
Permalink
Nicolas Connault added a comment -

then the hidden controls should be disabled in the gradebook, and a link to the quiz module form given. Currently it appears horridly buggy from the gradebook's point of view.

Show
Nicolas Connault added a comment - then the hidden controls should be disabled in the gradebook, and a link to the quiz module form given. Currently it appears horridly buggy from the gradebook's point of view.
Hide
Permalink
Michael Blake added a comment -

Received a request from Moodle Partner (Miguel Santos @ Moodlerooms) to raise the priority on this. No activity for a few months. Nico, you state the feature looks horribly buggy - what's required to fix?

Show
Michael Blake added a comment - Received a request from Moodle Partner (Miguel Santos @ Moodlerooms) to raise the priority on this. No activity for a few months. Nico, you state the feature looks horribly buggy - what's required to fix?
Hide
Permalink
Teresa Gibbison added a comment -

I have also noticed similar results when we edit the quiz activity itself, to reproduce

1. With a course which has a quiz, go to the gradebook
2. Turn editing on and click the edit button under the quiz to edit the quiz grade item.
3. Check the "Hidden" checkbox
4. Save changes
5. Go back to the quiz activity and update the settings - in our case we were adding a new password.
6. Go back to the gradebook - the quiz grade item is now available

Show
Teresa Gibbison added a comment - I have also noticed similar results when we edit the quiz activity itself, to reproduce 1. With a course which has a quiz, go to the gradebook 2. Turn editing on and click the edit button under the quiz to edit the quiz grade item. 3. Check the "Hidden" checkbox 4. Save changes 5. Go back to the quiz activity and update the settings - in our case we were adding a new password. 6. Go back to the gradebook - the quiz grade item is now available
Hide
Permalink
Teresa Gibbison added a comment -

Our current workaround = putting the hidden grade item into a hidden grade category. The students will not be able to view the item regardless of it's show/hide status because the category it belongs to is hidden.
I hope this helps anyone waiting for the fix!
Cheers
Teresa

Show
Teresa Gibbison added a comment - Our current workaround = putting the hidden grade item into a hidden grade category. The students will not be able to view the item regardless of it's show/hide status because the category it belongs to is hidden. I hope this helps anyone waiting for the fix! Cheers Teresa
Hide
Permalink
susan e added a comment -

an annoying but workable way to fix this problem from the users perspective.
go into the gradebook
turn editing on
click the edit button for a quiz
click the disable button right under the hidden check box
click the disable button right under the locked check box
save
the hidden setting will no longer be in effect and the quiz will be viewable

Show
susan e added a comment - an annoying but workable way to fix this problem from the users perspective. go into the gradebook turn editing on click the edit button for a quiz click the disable button right under the hidden check box click the disable button right under the locked check box save the hidden setting will no longer be in effect and the quiz will be viewable
Hide
Permalink
Helen Foster added a comment -

Thanks everyone for your comments. Not quite sure where we are with this issue, however I've just added gradebook expert Andrew as watcher for his consideration.

Show
Helen Foster added a comment - Thanks everyone for your comments. Not quite sure where we are with this issue, however I've just added gradebook expert Andrew as watcher for his consideration.
Hide
Permalink
Tim Hunt added a comment -

Note Petr's comment above that Nico's patches are the wrong approach. Note also that MDL-13978 is probably related.

Andrew, I would like it if someone could give me a clear answer as to how modules are supposed to interact with the gradebook. And if there is not a clear answer yet, please can we work one out for Moodle 2.1? Thanks.

Show
Tim Hunt added a comment - Note Petr's comment above that Nico's patches are the wrong approach. Note also that MDL-13978 is probably related. Andrew, I would like it if someone could give me a clear answer as to how modules are supposed to interact with the gradebook. And if there is not a clear answer yet, please can we work one out for Moodle 2.1? Thanks.
Hide
Permalink
Tim Hunt added a comment -

Removing the patch label, since the patches here do not seem to be useful, and I am trying to concentrate on all the quiz bugs with useful patches.

Show
Tim Hunt added a comment - Removing the patch label, since the patches here do not seem to be useful, and I am trying to concentrate on all the quiz bugs with useful patches.

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.