Moodle

Metacourse scenario 2

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: 1.9.1
  • Fix Version/s: None
  • Component/s: Roles / Access
  • Labels:
    None
  • Environment:
    linux
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_19_STABLE

Description

Unable to add users that don't have managemetacourse capability.

Well, I created modified the code to only allow people that has the moodle:course/request capability in the sync metacourse and in the admin/role/assign.php file to allow normal users to be added to metacourse.

So scenario 2 works well now. Unless I got something wrong. It is not needed for a user to be able to manage metacourses. We only want them to be added inside the course or in the parent course.

I tested my patch and it seems to work. I guess other thing should be modified as well. But it works.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Loïc Faure-Lacroix added a comment -

Anyone?
Can someone tell me if the patch I provided is Okay. If there is something wrong. Tell me, I'll do the necessary change.

Is there a reason why only the people with the managemetacourse capability can join a metacourse. While other users with normal roles can't.
Is there a way to achieve the scenario2 without giving the managemetacourse capability.

Unless the above is impossible without giving the manage metacourse capability. I'd like to know if there is any risk with the patch I made.

Thank you,
Loïc Faure-Lacroix

Show
Loïc Faure-Lacroix added a comment - Anyone? Can someone tell me if the patch I provided is Okay. If there is something wrong. Tell me, I'll do the necessary change. Is there a reason why only the people with the managemetacourse capability can join a metacourse. While other users with normal roles can't. Is there a way to achieve the scenario2 without giving the managemetacourse capability. Unless the above is impossible without giving the manage metacourse capability. I'd like to know if there is any risk with the patch I made. Thank you, Loïc Faure-Lacroix
Hide
Permalink
Helen Foster added a comment -

Loïc, thanks for your report and patch.

Sorry I'm unable to review your patch, however I suggest you post in the roles and capabilities forum http://moodle.org/mod/forum/view.php?id=6826 to ask why only users with the managemetacourse capability can join a metacourse.

Show
Helen Foster added a comment - Loïc, thanks for your report and patch. Sorry I'm unable to review your patch, however I suggest you post in the roles and capabilities forum http://moodle.org/mod/forum/view.php?id=6826 to ask why only users with the managemetacourse capability can join a metacourse.
Hide
Permalink
Loïc Faure-Lacroix added a comment -

Ok thank you, I'll ask on the forum then. It has already been asked but we got no answers so we made this patch to moodle.
I don't expect anything from the forum as I received no reply to the first thread.

Our problem is that we have this fix and it seems to work as expected. But we can't keep every fix for every features we fix.
Anyway, I'll give a try to the forum.

Show
Loïc Faure-Lacroix added a comment - Ok thank you, I'll ask on the forum then. It has already been asked but we got no answers so we made this patch to moodle. I don't expect anything from the forum as I received no reply to the first thread. Our problem is that we have this fix and it seems to work as expected. But we can't keep every fix for every features we fix. Anyway, I'll give a try to the forum.
Hide
Permalink
Caroline Moore added a comment -

I haven't tested Loïc's patch yet, but we discovered this same "bug" today. I would love to see the ability to manually add any user to a metacourse.

It makes no sense to me to use the "manage metacourse" capability as a criterion for adding a user to a metacourse. Only Administrators and users who are already enrolled as Teachers within the context of this metacourse have this capability enabled by default.

To make metacourses truly useful, teachers need to be able to add users manually to the metacourse. There are scenarios in which a user might need to be added to the metacourse but should not be able to see any of the child courses.

The "manage metacourse" capability should ONLY control a user's ability to add and remove child courses. Either there should be a separate capability to control who can manually add users to a metacourse, or it should rely on the same logic as a regular course. (E.g. if a Teacher can add students to a regular course, s/he should also be able to add students directly to a metacourse.)

Loïc, could you explain exactly what your patch does? We ran into problems trying to fix this within Moodle. We could allow people to be manually enrolled in the course, but when the course enrollments were synchronized with the child courses (e.g. when we tried to unenroll one of the manually-added users), ALL manually-added users (who did not have "manage metacourse" capability) were unenrolled. Have you found a way to make manual enrollments stick?

Show
Caroline Moore added a comment - I haven't tested Loïc's patch yet, but we discovered this same "bug" today. I would love to see the ability to manually add any user to a metacourse. It makes no sense to me to use the "manage metacourse" capability as a criterion for adding a user to a metacourse. Only Administrators and users who are already enrolled as Teachers within the context of this metacourse have this capability enabled by default. To make metacourses truly useful, teachers need to be able to add users manually to the metacourse. There are scenarios in which a user might need to be added to the metacourse but should not be able to see any of the child courses. The "manage metacourse" capability should ONLY control a user's ability to add and remove child courses. Either there should be a separate capability to control who can manually add users to a metacourse, or it should rely on the same logic as a regular course. (E.g. if a Teacher can add students to a regular course, s/he should also be able to add students directly to a metacourse.) Loïc, could you explain exactly what your patch does? We ran into problems trying to fix this within Moodle. We could allow people to be manually enrolled in the course, but when the course enrollments were synchronized with the child courses (e.g. when we tried to unenroll one of the manually-added users), ALL manually-added users (who did not have "manage metacourse" capability) were unenrolled. Have you found a way to make manual enrollments stick?
Hide
Permalink
Charles Fulton added a comment -

This takes managemetacourse off the table for user/course management but that's just half the problem. I don't see the course:request capability in my testing instance, and you'd need to add it to all the managers who already have managemetacourse plus all the students who get manually added, and I don't see any code doing that.

Show
Charles Fulton added a comment - This takes managemetacourse off the table for user/course management but that's just half the problem. I don't see the course:request capability in my testing instance, and you'd need to add it to all the managers who already have managemetacourse plus all the students who get manually added, and I don't see any code doing that.
Hide
Permalink
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
Hide
Permalink
Michael de Raadt added a comment -

I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Show
Michael de Raadt added a comment - I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.