Details
Bug
Closed
Minor
Description
blocks/online_users/block_online_users.php - line:119
This SQL query would always return 1 (number of instances the first userid in the returned SQL)
$usercount = count_records_sql("SELECT COUNT(u.id), u.id $from $where GROUP BY u.id");
The patch counts the distinct userids to correctly return the real userc ount. :-
$usercount = count_records_sql("SELECT COUNT(DISTINCT(u.id)) $from $where");
Attachments
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Hide
Séverin Terrier
added a comment -
In fact, for students (with no permission to see users list, see MDL-11984), the count seems OK 
But, as an admin, when >50 connected people, i only see (last 5 minutes: 1) 
Show
Séverin Terrier
added a comment - In fact, for students (with no permission to see users list, see MDL-11984), the count seems OK
But, as an admin, when >50 connected people, i only see (last 5 minutes: 1)
But, as an admin, when >50 connected people, i only see (last 5 minutes: 1) 
+1 for this issue.
When viewing the Online Users block, it always says 1 user is online:
(last 5 minutes: 1)
But actually there are several hundred users online.
Tim's patch above fixes the count.