[#MDL-18347] Correct lesson short answers not incrementing student score

Issue Details (XML | Word | Printable)

Key:	MDL-18347
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Critical
Assignee:	Mark Nielsen
Reporter:	Carl Keller
Votes:	1
Watchers:	4

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Correct lesson short answers not incrementing student score

Created: 21/Feb/09 09:51 PM Updated: 24/Mar/09 04:22 PM

Component/s:

Lesson

Affects Version/s:

1.9.4

Fix Version/s:

1.9.5

File Attachments:	1. lesson_shortanswer.patch (2 kB)
Environment:	php 5.2.8, V1.9.4+ (Build: 20090218), MySQL 5.0.67-community, Apache 2.2.11 (Unix), Perl 5.8.8, Operating system Linux Kernel 2.6.28

Database:	MySQL
Participants:	Carl Keller, Jerome Mouneyrac, Mark Nielsen and Paul Nijbakker
Security Level:	None
QA Assignee:	Jerome Mouneyrac
Resolved date:	18/Mar/09
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

Any time a question includes a short answer, the question attempt is recorded. However, the response is not recorded as correct even if it was correct. This causes the student score to be incorrect. The lesson pages process correctly. The correct feed back is displayed. Everything appears to work perfectly, except that he total score for the lesson is not incremented properly.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Carl Keller added a comment - 21/Feb/09 11:07 PM

I can provide a URL for this if you are interested. I just did not want it publicly displayed.

[ Permalink | « Hide ]

Carl Keller added a comment - 24/Feb/09 11:02 AM

There appears to be a connection between these two issues.

[ Permalink | « Hide ]

Paul Nijbakker added a comment - 24/Feb/09 03:27 PM

We are experiencing this same bug since our upgrade to version 1.9.4. It occurs in lessons in which questions are not custom graded. I hope it can be fixed. In the meantime I am checking my lessons and turning those with short answer questions to custom grading.

[ Permalink | « Hide ]

Carl Keller added a comment - 03/Mar/09 06:36 AM

HI!

Is anyone actively working on this issue? We have online courses that rely heavily on the lesson module, and they are crippled over this!

Thanks!

[ Permalink | « Hide ]

Mark Nielsen added a comment - 12/Mar/09 05:28 AM

I was able to reproduce the bug. Attached is a patch that fixes the bug and also fixes a notice that would appear at the end of the lesson when you type in an answer for the short answer question type that does not match any of the expected answers.

If someone could test the patch, that would be great. I tested it with custom scoring on and off and with a single correct and wrong answer.

[ Permalink | « Hide ]

Mark Nielsen added a comment - 18/Mar/09 01:29 AM

Committed the patch.

[ Permalink | « Hide ]

Jerome Mouneyrac added a comment - 24/Mar/09 04:22 PM

My test on 1.9:
I created a lesson with one Short Answer question page.
On this short answer question, I set one answer to score 10, another to score 21
As a student I answer the question with the score 10, the score and average are well displayed. Teacher can see the good score too.
Fixed.

Thank you for the report and the fix.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.