Issue Details (XML | Word | Printable)

Key: MDL-18396
Type: Bug Bug
Status: Open Open
Priority: Minor Minor
Assignee: Tim Hunt
Reporter: Oleg Sychev
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Inconsistence in review options handling on reviewing previews

Created: 27/Feb/09 11:22 AM   Updated: 01/Oct/09 05:40 AM
Return to search
Component/s: Quiz
Affects Version/s: 1.9.4
Fix Version/s: None

Issue Links:
Relates
 

Participants: Oleg Sychev and Tim Hunt
Security Level: None
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
When reviewing preview a responses is shown regardless of quiz review options, while feedback shown only if it allowed in preview options.

This has more serious implications because it is possible to edit questions while reviewing a preview. The page is get reloaded then, and the preview state can change from "right after finished" to another thing, so feedback may vanish from the page in the process.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Oleg Sychev added a comment - 27/Feb/09 11:26 AM
My suggestion is to have flag like SESSION->keepattemptstate during such editing would be not hard to implement to resolve difficults with page reloading on editing. Then overall inconsistence would be easy to resolve in favour of review options.

Tim Hunt added a comment - 27/Feb/09 12:06 PM
Improved 'Immediately after the attempt' handling is a separate issue: MDL-18395

Oleg Sychev added a comment - 27/Feb/09 08:50 PM
This isssue seems even more tied together because of even large inconsistency found: under some review options student can't see an attempt (with the questions) at all, and using them (except right after finishing) is a usual practice when a teacher want to protect his question bank. But they are not affected teachers reviewing a preview and for a good reason! This is settles for me a question about whether should previewing review respect review options - it should not, or if it will do it consistently teacher may end up been unable to do this.

There may be two ways of resolving this:
1) easy workaround that will do the job in most of the cases: either
a) rework "immediately after the attempt" to avoid time limit (it's actually nasty on multipaged quizzes review)
b)or consider every preview review as beem immediately after the attempt
2) overall solution - give a teacher controls on preview review page about what he can see - what will be seen by a student, or all information.


Oleg Sychev added a comment - 01/Oct/09 03:53 AM
Hmm ... it seems that I have an idea how to settle this. There are two ways to start preview now (at least in 1.9): using preview tab and using a button on intro tab. They are intentionally work different: first used to just look at the quiz, second lets a teacher to see things from the student perspective (i.e. time limit, warning dialog and so on).

I think that review options should resemle that too. I.e. if you starting preview using a tab, then it's review won't affected by quiz review options, while if you starting preview using a button quiz review options will be in place. This increase consistency and teacher will be able to select what mode he really want to use each time.


Tim Hunt added a comment - 01/Oct/09 05:33 AM
I think that is too mysterious.

A much easier to understand solution would be a clear selector on the review page, where the teacher can choose the state (immediately after the attempt, while the quiz is still open, or after the quiz is closed). The third choice should only be there if the quiz has a close date.


Oleg Sychev added a comment - 01/Oct/09 05:40 AM
Maybe too mysterious, thought it was you that described me this difference and insist it is a good one

Anyway, clear selection is definitely good solution. However I would like to add one more option: show all (in case no review options allow this but teacher want to see details for question verification for example).