Issue Details (XML | Word | Printable)

Key: MDL-18409
Type: Improvement Improvement
Status: Open Open
Priority: Minor Minor
Assignee: Gordon Bateson
Reporter: Gordon Bateson
Votes: 2
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Removing unused grade items

Created: 28/Feb/09 12:57 PM   Updated: 06/May/09 05:34 PM
Return to search
Component/s: Hotpot
Affects Version/s: 1.9, 1.9.1, 1.9.2, 1.9.3, 1.9.4
Fix Version/s: 2.0

Environment: Moodle 1.9

Participants: Gordon Bateson and Petr Skoda
Security Level: None
Difficulty: Moderate
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
It is possible to have grade items in the gradebook for activities which can only ever have a zero grade and this is potentially confusing to teachers.
Consider the following sequence of actions:

1. If you create a HotPot/Quiz/Glossary which initially has no grade, then no grade item is created.
2. If you then change the grade to a non-zero grade, a grade item is created.
3. However, if you then change the grade back to zero, the grade item is not deleted from the grade book

After step 1, the activity has no grade, and there is no grade item in the grade book.
After step 3, the activity has no grade and there *is* a grade item in the grade book.
I think this is confusing for teachers.

I have described this issue more clearly on the moodle.org forums:
 Removing unused grade items
 http://moodle.org/mod/forum/discuss.php?d=117424#p515812

As a temporary solution, I have added a form element to "mod/hotpot.mod_form.php", which will allow a teacher to force the removal of the grade item if the maximum grade is set to zero. However, a more comprehensive solution would be to modify "update_grade()" to remove the grade_item for zer-grade activities.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
gbateson committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 28/Feb/09 12:59 PM
MDL-18409: new message required for "Remove grade item" form element
MODIFY lang/en_utf8/hotpot.php   Rev. 1.10.4.3    (+2 -1 lines)
gbateson committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 28/Feb/09 01:00 PM
MDL-18409 new help file for "Remove grade item" form element
MODIFY lang/en_utf8/help/hotpot/Attic/removegradeitem.html   Rev. 1.1.2.1    (+13 -0 lines)
gbateson committed 4 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 28/Feb/09 01:03 PM
MDL-18409 add "Remove grade item" to mod_form.php form and standardize grade items for HotPots: (i) remove orphan grade items, (ii) remove grade items for HotPots with a zero grade, (iii) synchronize grade item name and HotPot name (iv) add missing grade items
MODIFY mod/hotpot/db/upgrade.php   Rev. 1.1.8.5    (+299 -4 lines)
MODIFY mod/hotpot/lib.php   Rev. 1.79.2.18    (+12 -2 lines)
MODIFY mod/hotpot/version.php   Rev. 1.48.2.4    (+3 -3 lines)
MODIFY mod/hotpot/mod_form.php   Rev. 1.2.2.6    (+22 -10 lines)
martignoni committed 1 file to 'Lang CVS' - 02/Mar/09 02:57 AM
MDL-18409 New string
MODIFY fr_utf8/hotpot.php   Rev. 1.16    (+2 -1 lines)
gbateson committed 1 file to 'Moodle CVS' - 30/Mar/09 03:09 PM
MDL-18409: new message required for "Remove grade item" form element
MODIFY lang/en_utf8/hotpot.php   Rev. 1.16    (+2 -1 lines)
Mitsuhiro Yoshida committed 5 files to 'Lang CVS' - 31/Mar/09 10:22 AM
MDL-18409 Translated a new string for hotpot.
MDL-17684 Adding a translated lang file for filter.
MDL-18540 Updated translated strings for "extra" memory strings based on lang/en_utf8 change.
MODIFY ja_utf8/admin.php   Rev. 1.348    (+3 -3 lines)
MODIFY ja_utf8/hotpot.php   Rev. 1.35    (+2 -1 lines)
ADD ja_utf8/filter_tidy.php   Rev. 1.1    (+0 -0 lines)
MODIFY ja_utf8/README   Rev. 1.967    (+1 -1 lines)
MODIFY ja_utf8/moodle.php   Rev. 1.352    (+2 -1 lines)
Petr Skoda added a comment - 06/May/09 05:34 PM
This is a known problem

Petr Skoda made changes - 06/May/09 05:34 PM
Field Original Value New Value
Fix Version/s 2.0 [ 10122 ]
Fix Version/s 1.9.5 [ 10320 ]
martignoni committed 1 file to 'Lang CVS' - 04/Aug/09 02:43 AM
MDL-18409 new help file for "Remove grade item" form element
This help file exists only in MOODLE_19_STABLE branch
ADD fr_utf8/help/hotpot/removegradeitem.html   Rev. 1.1    (+0 -0 lines)