[#MDL-18416] The web page to edit RSS doesn't validate. Breaks XHTML strict.

Issue Details (XML | Word | Printable)

Key:	MDL-18416
Type:	Bug
Status:	Open
Priority:	Major
Assignee:	moodle.com
Reporter:	Daniele Cordella
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

The web page to edit RSS doesn't validate. Breaks XHTML strict.

Created: 02/Mar/09 05:04 AM Updated: 02/Apr/09 07:00 AM

Return to search

Component/s:

Accessibility, RSS

Affects Version/s:

1.9.4

Fix Version/s:

None

File Attachments:

MDL-18416.patch (0.4 kB)

Participants:	Daniele Cordella, Jose Cedeno and moodle.com
Security Level:	None
Affected Branches:	MOODLE_19_STABLE

Description

« Hide

Add a feed to a course (I added it to the home page).
Configure it properly adding the right XML address for a feed.
Now edit your just added feed by going to:
RSS feed block -> Add/Edit Feeds -> click the "Edit" icon on the right of the feed XML path.
You get a page (what I get is: http://yourMoodleSite/blocks/rss_client/block_rss_client_action.php?id=1&act=rssedit&rssid=1&shared=0&blogid=)
that is missing the close form tag. (</form>)

Of course, this page doesn't validate.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Jose Cedeno added a comment - 02/Apr/09 07:00 AM

I can confirm the bug that Daniele reported. I'm also attaching a patch that should take care of it. I've tested the patch and works for me.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.