Moodle

The web page to edit RSS doesn't validate. Breaks XHTML strict.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.4
  • Fix Version/s: 1.9.6
  • Component/s: Accessibility, RSS
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Add a feed to a course (I added it to the home page).
Configure it properly adding the right XML address for a feed.
Now edit your just added feed by going to:
RSS feed block -> Add/Edit Feeds -> click the "Edit" icon on the right of the feed XML path.
You get a page (what I get is: http://yourMoodleSite/blocks/rss_client/block_rss_client_action.php?id=1&act=rssedit&rssid=1&shared=0&blogid=)
that is missing the close form tag. (</form>)

Of course, this page doesn't validate.

Activity

Hide
Jose Cedeno added a comment -

I can confirm the bug that Daniele reported. I'm also attaching a patch that should take care of it. I've tested the patch and works for me.

Show
Jose Cedeno added a comment - I can confirm the bug that Daniele reported. I'm also attaching a patch that should take care of it. I've tested the patch and works for me.
Hide
Dan Marsden added a comment -

This looks like it was fixed in a different way by Tim here
http://cvs.moodle.org/moodle/lib/rsslib.php?r1=1.52.2.5&r2=1.52.2.6&pathrev=MOODLE_19_STABLE

let me know if it's still a problem and I'll reopen the bug.

Show
Dan Marsden added a comment - This looks like it was fixed in a different way by Tim here http://cvs.moodle.org/moodle/lib/rsslib.php?r1=1.52.2.5&r2=1.52.2.6&pathrev=MOODLE_19_STABLE let me know if it's still a problem and I'll reopen the bug.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: