Moodle

Restore XML parsing: Improve for speed by skipping non-selected modules

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.4
  • Fix Version/s: 1.9.5
  • Component/s: Backup
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Right now, when a course is restored... no matter of the activities selected to be restored, the whole <MODULES> part of the backup file is parsed and all modules are xmlized.

This is an excess of processing. Try to optimise it by being more selective... ciao

Issue Links

This issue has a non-specific relationship to:
MDL-15489 Restore fails: Could not restore modules! Critical Open
This issue has been marked as being related by:
MDL-18468 Restore XML parsing: Improve for speed by preprocessing and splitting moodle.xml Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Resolving as fixed.

Now, activities that have been not selected to be restored, aren't processed anymore avoiding previous excess of process, iow, speed gain.

Note that, as side effect, this causes that in some course restores breaking previously, now it's possible to workaround the problem by restoring over the same course multiple times, selecting different activities on each restore until complete the whole set (this can help to MDL-15489 until proper fix is committed for it).

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Resolving as fixed. Now, activities that have been not selected to be restored, aren't processed anymore avoiding previous excess of process, iow, speed gain. Note that, as side effect, this causes that in some course restores breaking previously, now it's possible to workaround the problem by restoring over the same course multiple times, selecting different activities on each restore until complete the whole set (this can help to MDL-15489 until proper fix is committed for it). Ciao
Hide
Permalink
Petr Škoda (skodak) added a comment -

reviewed and tested, everything seems to work fine, thanks!

Show
Petr Škoda (skodak) added a comment - reviewed and tested, everything seems to work fine, thanks!

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.