Issue Details (XML | Word | Printable)

Key: MDL-18486
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Dongsheng Cai
Reporter: Dongsheng Cai
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-13766

Move file picker code to a static javascript file

Created: 09/Mar/09 02:07 PM   Updated: 04/May/09 11:35 PM
Return to search
Component/s: Repository API
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Dongsheng Cai and Tim Hunt
Security Level: None
QA Assignee: Tim Hunt
Difficulty: Moderate
Resolved date: 04/May/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
If there are muliti-filepicker, javascript code will be loaded reduplicately, that is because filepicker use php generated code in it.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dongsheng Cai made changes - 09/Mar/09 02:10 PM
Field Original Value New Value
Issue Type Improvement [ 4 ] Sub-task [ 5 ]
Parent MDL-13766 [ 25249 ]
Dongsheng Cai committed 10 files to 'Moodle CVS' - 20/Apr/09 04:53 PM
"MDL-18486, remove php varible from file picker code, all javascript code goes into a static file"
MODIFY lib/form/filepicker.php   Rev. 1.23    (+10 -10 lines)
MODIFY lib/form/filemanager.php   Rev. 1.9    (+26 -16 lines)
MODIFY lib/form/editor.php   Rev. 1.10    (+5 -5 lines)
MODIFY lib/editor/tinymce/Attic/tinymce.js.php   Rev. 1.5    (+4 -4 lines)
MODIFY lib/Attic/javascript.php   Rev. 1.47    (+3 -3 lines)
ADD repository/repository.js   Rev. 1.1    (+0 -0 lines)
MODIFY repository/Attic/ws.php   Rev. 1.52    (+28 -20 lines)
DEL repository/Attic/javascript.php   Rev. 1.66    (+0 -0 lines)
MODIFY repository/lib.php   Rev. 1.167    (+172 -2 lines)
MODIFY lib/weblib.php   Rev. 1.1230    (+6 -5 lines)
Dongsheng Cai made changes - 20/Apr/09 04:53 PM
Status Open [ 1 ] In Progress [ 3 ]
[ Permalink | « Hide ]
Dongsheng Cai added a comment - 20/Apr/09 04:54 PM
Commited new file picker 2.0.
Searching function is not available yet.

Dongsheng Cai committed 1 file to 'Moodle CVS' - 20/Apr/09 05:08 PM
"MDL-18486, should post client_id to server when cleaning cache"
MODIFY repository/repository.js   Rev. 1.2    (+2 -1 lines)
Dongsheng Cai committed 6 files to 'Moodle CVS' - 21/Apr/09 01:53 PM
"MDL-18486, file picker searching form"
MODIFY repository/alfresco/repository.class.php   Rev. 1.10    (+12 -12 lines)
MODIFY repository/flickr_public/repository.class.php   Rev. 1.39    (+8 -7 lines)
MODIFY repository/repository.js   Rev. 1.3    (+100 -47 lines)
MODIFY repository/lib.php   Rev. 1.168    (+7 -6 lines)
MODIFY repository/Attic/ws.php   Rev. 1.54    (+4 -2 lines)
MODIFY repository/upload/repository.class.php   Rev. 1.13    (+16 -34 lines)
Dongsheng Cai committed 1 file to 'Moodle CVS' - 22/Apr/09 10:12 AM
"MDL-18486, fixed cancel button, and iframe view"
MODIFY repository/repository.js   Rev. 1.4    (+26 -8 lines)
Dongsheng Cai committed 1 file to 'Moodle CVS' - 28/Apr/09 10:17 AM
"MDL-18486, fixed popup window callabck function bug"
MODIFY repository/repository.js   Rev. 1.9    (+6 -7 lines)
Dongsheng Cai committed 1 file to 'Moodle CVS' - 30/Apr/09 11:39 AM
"MDL-18486, add key lisener to file picker"
MODIFY repository/repository.js   Rev. 1.11    (+14 -2 lines)
Dongsheng Cai committed 1 file to 'Moodle CVS' - 30/Apr/09 02:11 PM
"MDL-18486, enable federated search for new file picker"
MODIFY repository/repository.js   Rev. 1.12    (+68 -5 lines)
Dongsheng Cai committed 2 files to 'Moodle CVS' - 30/Apr/09 02:30 PM
"MDL-18486, compressed file picker js code"
ADD repository/repository.src.js   Rev. 1.1    (+0 -0 lines)
MODIFY repository/repository.js   Rev. 1.13    (+1 -1145 lines)
Dongsheng Cai committed 4 files to 'Moodle CVS' - 30/Apr/09 05:42 PM
"MDL-18486, 1. hide toolbar, pagination when doing global searching, 2. display empty directory in local pluign"
MODIFY repository/repository.js   Rev. 1.14    (+1 -1 lines)
MODIFY repository/Attic/ws.php   Rev. 1.59    (+2 -1 lines)
MODIFY repository/lib.php   Rev. 1.170    (+36 -37 lines)
MODIFY repository/repository.src.js   Rev. 1.2    (+10 -1 lines)
[ Permalink | « Hide ]
Dongsheng Cai added a comment - 04/May/09 02:34 PM
The new file picker worked, feel free to reopen it.

Dongsheng Cai made changes - 04/May/09 02:34 PM
Resolution Fixed [ 1 ]
Status In Progress [ 3 ] Resolved [ 5 ]
[ Permalink | « Hide ]
Tim Hunt added a comment - 04/May/09 11:35 PM
Thanks Dongsheng!


Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators