Moodle

Develop a repository plugin to access file system and move SMB out from core

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Repositories
  • Labels:
    None
  • Environment:
    Linux

Description

SysAdmin create a directory on local server, moodle repository api will access this directory as repository.

BTW, this directory can be mounted from a remote server (for example, use sshfs or samba mount a remote server to local file system).

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dongsheng Cai added a comment -

Plugin created

Show
Dongsheng Cai added a comment - Plugin created
Hide
Permalink
Martin Dougiamas added a comment -

This is working well, but there is a big problem with security currently.

It's too easy for the admin to check "course and user repositories", which basically lets every user see any file on the server operating system.

We need some solution to allow users to pick folders from a limited subdirectory, and perhaps we even need to force admins to specify such a directory.

Possibly users should never get to choose a directory (but the admin can set it for them).

Show
Martin Dougiamas added a comment - This is working well, but there is a big problem with security currently. It's too easy for the admin to check "course and user repositories", which basically lets every user see any file on the server operating system. We need some solution to allow users to pick folders from a limited subdirectory, and perhaps we even need to force admins to specify such a directory. Possibly users should never get to choose a directory (but the admin can set it for them).
Hide
Permalink
Martin Dougiamas added a comment -

Much better, but I still have some suggestions for the settings screen for this plugin.

1) When you first go in there you get an empty menu because there are no subdirectories. In this case you should not get a menu but instead should see: "You need to create at least one folder inside the moodledata/repository directory so you can select it here."

2) Afterwards, the explanation text should say "These folders are within the moodledata/repository directory."

Show
Martin Dougiamas added a comment - Much better, but I still have some suggestions for the settings screen for this plugin. 1) When you first go in there you get an empty menu because there are no subdirectories. In this case you should not get a menu but instead should see: "You need to create at least one folder inside the moodledata/repository directory so you can select it here." 2) Afterwards, the explanation text should say "These folders are within the moodledata/repository directory."
Hide
Permalink
Dongsheng Cai added a comment -

Thanks Martin

Your suggestions has been implemented

Show
Dongsheng Cai added a comment - Thanks Martin Your suggestions has been implemented
Hide
Permalink
Petr Škoda (skodak) added a comment -

oops, <b> tag is not xhtml strict

Show
Petr Škoda (skodak) added a comment - oops, <b> tag is not xhtml strict
Hide
Permalink
Dongsheng Cai added a comment -

Petr:

<b>, <i> still allowed in XHTML 1.x, but absent from XHTML 2.0, http://www.w3.org/TR/xhtml-modularization/abstract_modules.html#s_presentationmodule

Show
Dongsheng Cai added a comment - Petr: <b>, <i> still allowed in XHTML 1.x, but absent from XHTML 2.0, http://www.w3.org/TR/xhtml-modularization/abstract_modules.html#s_presentationmodule
Hide
Permalink
Martin Dougiamas added a comment -

I added some docs http://docs.moodle.org/en/admin/repository/filesystem

While doing this I noticed that the filesystem module doesn't actually respect the mimetypes and shows all files all the time. Is this a bug?

Show
Martin Dougiamas added a comment - I added some docs http://docs.moodle.org/en/admin/repository/filesystem While doing this I noticed that the filesystem module doesn't actually respect the mimetypes and shows all files all the time. Is this a bug?
Hide
Permalink
Dongsheng Cai added a comment -

Martin, I added the filter yesterday, please try again, it should be ok now.

Show
Dongsheng Cai added a comment - Martin, I added the filter yesterday, please try again, it should be ok now.

People

Vote (2)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.