Moodle

Too string filtering in feedback form return smashes

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.9.4
  • Fix Version/s: None
  • Component/s: Feedback
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

Ligne ยง176 of complete.php shows

$post = clean_param($_POST, PARAM_ALPHANUM);

which is far too strict for long text inputs. Smashes the free text removing spaces and twicking all UTF8 accentuated chars.

should be PARAM_TEXT.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andreas Grabs added a comment -

Hi Valery,

I'm sorry, but I can't find such line . Can you check, what version of the feedback do you use?

Andreas

Show
Andreas Grabs added a comment - Hi Valery, I'm sorry, but I can't find such line . Can you check, what version of the feedback do you use? Andreas
Hide
Permalink
Valery Fremaux added a comment -

Hi Andreas, was suspecting something like that :

$module->version = 2008050111;

I update my MOODLE_STABLE_19... and check.

Show
Valery Fremaux added a comment - Hi Andreas, was suspecting something like that : $module->version = 2008050111; I update my MOODLE_STABLE_19... and check.
Hide
Permalink
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
Hide
Permalink
Michael de Raadt added a comment -

I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Show
Michael de Raadt added a comment - I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.