Moodle

login https is not working when NTLM is enabled, but authentication fails

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.4
  • Fix Version/s: 1.9.6, 2.0
  • Component/s: Authentication
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

I have loginhttps enabled and NTLM enabled for IPs within the organisation, but some machines which are not part of the domain, or use firefox go to the offcampus login page. This page is not encrypted with https, although it should be.

Issue Links

This issue has been marked as being related by:
MDL-14584 META: NTLM problems Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Iñaki Arenaza added a comment -

Hi Matt,

I thinks this is fixed as part of the MDL-14078 fix I commited on 2009.02.14 for 1.9 and HEAD. Is your 1.9.4 version older or newer than that date?

If the last two lines (except the closing '}') from .../auth/ldap/ntlmsso_finish.php are:

redirect($CFG->httpswwwroot . '/login/index.php?authldap_skipntlmsso=1',
get_string('ntlmsso_failed','auth'), 3);

and you still have this issue, I'll try to debug and fix it with your help

Saludos. Iñaki.

Show
Iñaki Arenaza added a comment - Hi Matt, I thinks this is fixed as part of the MDL-14078 fix I commited on 2009.02.14 for 1.9 and HEAD. Is your 1.9.4 version older or newer than that date? If the last two lines (except the closing '}') from .../auth/ldap/ntlmsso_finish.php are: redirect($CFG->httpswwwroot . '/login/index.php?authldap_skipntlmsso=1', get_string('ntlmsso_failed','auth'), 3); and you still have this issue, I'll try to debug and fix it with your help Saludos. Iñaki.
Hide
Permalink
Iñaki Arenaza added a comment -

Matt,

I've been testing this a bit, and it seems there's actually a bug when you have the 'MS IE Fast Path' option enabled (otherwise it works as expected with the 1.9.4 current as of today).

Could you please try the attached patch?

Saludos. Iñaki.

Show
Iñaki Arenaza added a comment - Matt, I've been testing this a bit, and it seems there's actually a bug when you have the 'MS IE Fast Path' option enabled (otherwise it works as expected with the 1.9.4 current as of today). Could you please try the attached patch? Saludos. Iñaki.
Hide
Permalink
Iñaki Arenaza added a comment -

The previous patch seems to be bogus and doesn't apply cleanly (I just don't know why, as I created it with git). Anyway, please use this one better

Iñaki.

Show
Iñaki Arenaza added a comment - The previous patch seems to be bogus and doesn't apply cleanly (I just don't know why, as I created it with git). Anyway, please use this one better Iñaki.
Hide
Permalink
Petr Škoda (skodak) added a comment -

patch looks ok, reassigning, please commit after some more testing

Show
Petr Škoda (skodak) added a comment - patch looks ok, reassigning, please commit after some more testing
Hide
Permalink
Iñaki Arenaza added a comment -

Matt,

did you try my last patch? If so, did it fix your issue?

Saludos. Iñaki.

Show
Iñaki Arenaza added a comment - Matt, did you try my last patch? If so, did it fix your issue? Saludos. Iñaki.
Hide
Permalink
Iñaki Arenaza added a comment -

Fixed in CVS for both 1.9 and HEAD.

Thanks a lot Matt for the report!

Saludos.
Iñaki.

Show
Iñaki Arenaza added a comment - Fixed in CVS for both 1.9 and HEAD. Thanks a lot Matt for the report! Saludos. Iñaki.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.