Moodle

Resource type names cannot be put in their own local lang files

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8.8, 1.9.4
  • Fix Version/s: 1.8.9, 1.9.5
  • Component/s: Resource
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

Custom resource type plugins can have their own lang/ directory under /mod/resource/type/foo/lang/

However, the name of the resource type itself has to be in the 'resource' namespace.

e.g. $string['resourcetypefoo'] = 'Link to a Foo document';

Activity

Hide
Francois Marier added a comment -

Patch against 1.9 stable

Show
Francois Marier added a comment - Patch against 1.9 stable
Hide
Francois Marier added a comment -

Updated patch based on Tim Hunt's comments.

Show
Francois Marier added a comment - Updated patch based on Tim Hunt's comments.
Hide
Francois Marier added a comment -

Fixed in 1.8, 1.9 and HEAD.

Show
Francois Marier added a comment - Fixed in 1.8, 1.9 and HEAD.
Hide
Sam Hemelryk added a comment -

Hi Francois,
I was just looking to close this issue but wanted to check one thing with you before hand,
Should the resource name stored in /mod/resource/type/foo/lang/en_utf8/resource_foo.php be used in the editing drop downs should it exist?
If not then everything is fine and I will close the issue otherwise I have attached a small patch that uses the function you created for this patch to put the /mod/resource/type/foo/lang/en_utf8/resource_foo.php resource name into the drop downs when in editing mode and looking to add a resource.

Cheers
Sam

Show
Sam Hemelryk added a comment - Hi Francois, I was just looking to close this issue but wanted to check one thing with you before hand, Should the resource name stored in /mod/resource/type/foo/lang/en_utf8/resource_foo.php be used in the editing drop downs should it exist? If not then everything is fine and I will close the issue otherwise I have attached a small patch that uses the function you created for this patch to put the /mod/resource/type/foo/lang/en_utf8/resource_foo.php resource name into the drop downs when in editing mode and looking to add a resource. Cheers Sam
Hide
Francois Marier added a comment -

Hi Sam,

I must have forgotten that case. Please do apply your patch

Cheers,
Francois

Show
Francois Marier added a comment - Hi Sam, I must have forgotten that case. Please do apply your patch Cheers, Francois
Hide
Sam Hemelryk added a comment -

Closing this issue as I can be sure it works and my involvement was VERY minimal, Thanks Francois

Show
Sam Hemelryk added a comment - Closing this issue as I can be sure it works and my involvement was VERY minimal, Thanks Francois

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: