Details
-
Type:
Bug
-
Status:
Open
-
Priority:
Minor
-
Resolution: Unresolved
-
Affects Version/s: 1.9.4
-
Fix Version/s: None
-
Component/s: MNet
-
Labels:None
-
Difficulty:Easy
-
Affected Branches:MOODLE_19_STABLE
Description
In /course/report/log/index.php, print_mnet_log is called with the second argument being the course ID, rather than the entire course object. However, print_mnet_log in /course/lib.php still tries to access $course->id, which of course fails. Probably the easiest fix is to replace "$course->id" with just "$course" within print_mnet_log. Additionally, it may be good to rename the variable to be "$courseid" instead of just "$course", to make things clearer.
Attachments
Issue Links
| This issue will help resolve: | ||||
| MDL-21260 | General open bugs |
|
|
|
Activity
Hi Penny,
Sorry, I finally un-broke My Moodle, and managed to figure out how to trigger this code. 
Your patch needs this additional diff for /course/lib.php:
@@ -139,11 +149,11 @@ function build_mnet_logs_array($hostid, $course, $user=0, $date=0, $order="l.tim
WHERE
";
- $where .= "l.hostid = '$hostid'";
+ $where = "l.hostid = '$hostid'";
// TODO: Is 1 really a magic number referring to the sitename?
- if ($course != 1 || $modid != 0) {
- $where .= " AND\n l.course='$course'";
+ if ($courseid != 1 || $modid != 0) {
+ $where .= " AND\n l.course='$courseid'";
}
if ($modname) {
(the modification to the "$where =" line isn't strictly required, but gets rid of a warning in debugging mode)
Otherwise, the patch is good.
Your patch needs this additional diff for /course/lib.php:
@@ -139,11 +149,11 @@ function build_mnet_logs_array($hostid, $course, $user=0, $date=0, $order="l.tim
WHERE
";
- $where .= "l.hostid = '$hostid'";
+ $where = "l.hostid = '$hostid'";
// TODO: Is 1 really a magic number referring to the sitename?
- if ($course != 1 || $modid != 0) {
- $where .= " AND\n l.course='$course'";
+ if ($courseid != 1 || $modid != 0) {
+ $where .= " AND\n l.course='$courseid'";
}
if ($modname) {
ok, final patches attached for 1.9 and 2.0. please make sure you're happy with them and then i'll commit 
and thanks heaps for helping!
and thanks heaps for helping! 
the second param for the function print_mnet_log has been changed from $id to $course.
This approach is better than changing the body of function to use $course instead of $course->id because print_mnet_log calls build_mnet_logs_array which also requires the $course object.