Details
Bug
Minor
Description
teachers complaint to me that the HTML layouts (rich formatting) they apply to the intro box of forums does not
show up after they apply it and show it to the students.
especially problematic when some of the text is justified to the right (Hebrew rtl) and some instructions are
(supposed to be) justified to the left (English ltr)
so i found out that the intro field is filtered by the format_text() function.
i removed it since i see no point (security wise) to have this specific piece of content filtered since the teachers
are responsible for the content and most of the time they try to embed multimedia and rich HTML code for the
benefit of the students.
so i change mod/forum/view.php (line 260) from
print_box(format_text($forum->intro), 'generalbox', 'intro');
to...
print_box($forum->intro, 'generalbox', 'intro');
i hope it is ok 
Attachments
Issue Links
| This issue will be resolved by: | ||||
| MDL-16072 | File storage conversion Forum |
|
|
|
Activity
Awantha - thank you for you solution.
we adopted this approach with minor variations (as necessary on different places)
Martin - maybe we should open different sub-issues for the different places in the code
in which issues like this occur.
teacher should defently have more freedom to embed (external code) and format any resource or activity's INTRO
box as they like with no limitation (and be responsible for that, i hope
students should be able to to have similar abilities in blogs, forums posts and comments...
but controlled by admin's setting (as it is right now)
examples:
(formatting of text by teachers trying to justify mix ltr and rtl text was removed,
until these changes were applied)
calendar/lib.php (lines 548~)
$options = new stdClass;
$options->noclean = true;
echo format_text($event->description, FORMAT_HTML,$options);
mod/forum/view.php (lines 234~ and 261~)
if (!empty($forum->intro)) {
$options = new stdClass;
$options->noclean = true;
print_box(format_text($forum->intro,$options), 'generalbox', 'intro');
}
mod/choice/view.php (lines ~83)
if ($choice->text) {
$options = new stdClass;
$options->noclean = true;
print_box(format_text($choice->text, $choice->format,$options), 'generalbox', 'intro');
}
some 3rd party modules too...
students should be able to to have similar abilities in blogs, forums posts and comments...
but controlled by admin's setting (as it is right now)
examples:
(formatting of text by teachers trying to justify mix ltr and rtl text was removed,
until these changes were applied)
calendar/lib.php (lines 548~)
$options = new stdClass;
$options->noclean = true;
echo format_text($event->description, FORMAT_HTML,$options);
mod/forum/view.php (lines 234~ and 261~)
if (!empty($forum->intro)) {
$options = new stdClass;
$options->noclean = true;
print_box(format_text($forum->intro,$options), 'generalbox', 'intro');
}
mod/choice/view.php (lines ~83)
if ($choice->text) {
$options = new stdClass;
$options->noclean = true;
print_box(format_text($choice->text, $choice->format,$options), 'generalbox', 'intro');
}
some 3rd party modules too...
I think format_text() function is a pretty important one as it converts the input text to
html format while including proper line breaks and paragraph tags appropriately. What I suggest
is to remove the clean up of tags since the teachers are responsible for the proper content.
So I suggest to include
$options->noclean = true;
just before the
print_box(format_text($forum->intro), 'generalbox', 'intro');
function.
Thanks!
Oshadi