Moodle

Maximum and Minimum limits on block width are hard-coded in several view pages.

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9, 1.9.1, 1.9.2, 1.9.3, 1.9.4
  • Fix Version/s: 2.0
  • Labels:
    None
  • Environment:
    All
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

In the following files the upper and lower limits of the bounded values calculated for block widths are hard-coded:

/admin/stickyblocks.php
/mod/chat/view.php
/mod/data/view.php
/mod/lesson/view.php
/mod/lesson/action/continue.php
/mod/quiz/view.php
/mod/resource/lib.php
/my/index.php
/tag/index.php

Consider replacing hard-coding with variables as index.php etc., as this prevent settings in $THEME (in the theme config.php) from having effect <180 or >210px.

http://moodle.org/mod/forum/discuss.php?d=119595#p526666
gives some details.

Activity

Hide
Tim Hunt added a comment -

This will probably get sorted as part of http://docs.moodle.org/en/Development:Navigation_2.0

Show
Tim Hunt added a comment - This will probably get sorted as part of http://docs.moodle.org/en/Development:Navigation_2.0
Hide
John White added a comment -

Thanks Tim.
I have also added a reference to this tracker number in Development:Navigation_2.0 in the references section.
John

Show
John White added a comment - Thanks Tim. I have also added a reference to this tracker number in Development:Navigation_2.0 in the references section. John
Hide
Tim Hunt added a comment -

This was fixed by my changes for MDL-19077.

Show
Tim Hunt added a comment - This was fixed by my changes for MDL-19077.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: