Moodle

course search box misaligned

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Won't Fix
  • Affects Version/s: 1.9.4
  • Fix Version/s: None
  • Component/s: Course
  • Labels:
    None
  • Environment:
    Firefox 3.0.8
  • Affected Branches:
    MOODLE_19_STABLE

Description

After performing a course search, the search box in the upper right is misaligned in Firefox 3.0.8. It is correct in Internet Explorer 8.

Attachments

  1. Text File
    MDL-18831.patch
    05/May/09 1:09 PM
    0.9 kB
    Jose Cedeno
  2. Text File
    replacing-fieldset-with-div.patch
    05/May/09 1:24 PM
    0.9 kB
    Jose Cedeno
  1. search.png
    3 kB
    10/Apr/09 8:34 PM

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jose Cedeno added a comment -

I was trying to work on a patch for this issue, but I need a little more information. Is there a specific theme you are using? If it's another moodle site that is giving you a problem, do you have a link to the page showing the error?

Show
Jose Cedeno added a comment - I was trying to work on a patch for this issue, but I need a little more information. Is there a specific theme you are using? If it's another moodle site that is giving you a problem, do you have a link to the page showing the error?
Hide
Permalink
Ryan Smith added a comment -

Jose,

I am using the standard theme on a fresh Moodle install of version 1.9.4. To reproduce it, visit the 'All courses' link in the courses block, now you're at:

/moodle/course/index.php

See the search courses box? search for a course you know exists, then on the resulting search page you'll see the misaligned box in my screenshot I attached.

Show
Ryan Smith added a comment - Jose, I am using the standard theme on a fresh Moodle install of version 1.9.4. To reproduce it, visit the 'All courses' link in the courses block, now you're at: /moodle/course/index.php See the search courses box? search for a course you know exists, then on the resulting search page you'll see the misaligned box in my screenshot I attached.
Hide
Permalink
Jose Cedeno added a comment -

This fixes the problem in firefox. I don't have Internet Explorer, so I cannot test the patch in that browser. I have tested in Firefox in the Mac as well as in Safari.

Show
Jose Cedeno added a comment - This fixes the problem in firefox. I don't have Internet Explorer, so I cannot test the patch in that browser. I have tested in Firefox in the Mac as well as in Safari.
Hide
Permalink
Jose Cedeno added a comment -

Tim Hunt provided pointed out in my earlier patch that fieldsets are required for accessibility reasons and removing it, might break other themes. In this patch, I replaced the fieldset with a div.

Show
Jose Cedeno added a comment - Tim Hunt provided pointed out in my earlier patch that fieldsets are required for accessibility reasons and removing it, might break other themes. In this patch, I replaced the fieldset with a div.
Hide
Permalink
Martín Langhoff added a comment -

I have to agree with Tim – the fieldsets are required for accesibility. A div doesn't mean the same (in the 'semantic html' sense) as a fieldset tag.

If it gets "fixed" replacing a fieldset with a div, maybe FF attaches some CSS behaviour to the fieldset, which we need to override in the 'invisiblefieldset' css class?

Show
Martín Langhoff added a comment - I have to agree with Tim – the fieldsets are required for accesibility. A div doesn't mean the same (in the 'semantic html' sense) as a fieldset tag. If it gets "fixed" replacing a fieldset with a div, maybe FF attaches some CSS behaviour to the fieldset, which we need to override in the 'invisiblefieldset' css class?
Hide
Permalink
Ryan Smith added a comment -

I just tested this again in Firefox 3.6 and Moodle 1.9.7+ and it seems to be fixed. The search box is aligned properly. I think this can be closed.

Show
Ryan Smith added a comment - I just tested this again in Firefox 3.6 and Moodle 1.9.7+ and it seems to be fixed. The search box is aligned properly. I think this can be closed.
Hide
Permalink
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
Hide
Permalink
Michael de Raadt added a comment -

I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Show
Michael de Raadt added a comment - I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.