|
[
Permalink
| « Hide
]
Jose Cedeno added a comment - 04/May/09 02:00 AM
I was trying to work on a patch for this issue, but I need a little more information. Is there a specific theme you are using? If it's another moodle site that is giving you a problem, do you have a link to the page showing the error?
Jose,
I am using the standard theme on a fresh Moodle install of version 1.9.4. To reproduce it, visit the 'All courses' link in the courses block, now you're at: /moodle/course/index.php See the search courses box? search for a course you know exists, then on the resulting search page you'll see the misaligned box in my screenshot I attached. This fixes the problem in firefox. I don't have Internet Explorer, so I cannot test the patch in that browser. I have tested in Firefox in the Mac as well as in Safari.
Tim Hunt provided pointed out in my earlier patch that fieldsets are required for accessibility reasons and removing it, might break other themes. In this patch, I replaced the fieldset with a div.
I have to agree with Tim – the fieldsets are required for accesibility. A div doesn't mean the same (in the 'semantic html' sense) as a fieldset tag.
If it gets "fixed" replacing a fieldset with a div, maybe FF attaches some CSS behaviour to the fieldset, which we need to override in the 'invisiblefieldset' css class? I just tested this again in Firefox 3.6 and Moodle 1.9.7+ and it seems to be fixed. The search box is aligned properly. I think this can be closed.
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Open
Trivial
course search box misaligned
 |
|
All content on this web site is made available under the GNU General Public License, unless otherwise stated.
