Moodle

CLONE - Some types of question imports require additional options

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.9.4
  • Fix Version/s: None
  • Component/s: Questions
  • Labels:
    None
  • Environment:
    All
  • Affected Branches:
    MOODLE_19_STABLE

Description

Question import require additional options.

For example, new version of gift import (GIFT with images) require select folder for images and some other useful options.
I suggest a proposal to do import in two steps: first for select a format and second for additional parameters and choosing file.

Attached patch make "two steps" import is fully compatible with all standard import types and don't require any modification of these.
See screenshots.

Issue Links

This issue has a clone:
MDL-5862 Question import require additional options Minor Closed
This issue will be resolved by:
MDL-28370 Should be a manage question import/export formats admin page Minor Open

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dmitry Pupinin added a comment -

Name of each additional parameter in second step should start from 'fao_' (format's additional option)

Show
Dmitry Pupinin added a comment - Name of each additional parameter in second step should start from 'fao_' (format's additional option)
Hide
Permalink
Dmitry Pupinin added a comment -

Example of using additional options you can see in "GIFT with images" format.
See attachment giftwithimg_format.zip

Full information about "GIFT with images" format will be available in near feature. It's testing now.
In detail see http://moodle.org/mod/forum/discuss.php?d=118007 (russian language. Use BabelFish or Google Translator)

Show
Dmitry Pupinin added a comment - Example of using additional options you can see in "GIFT with images" format. See attachment giftwithimg_format.zip Full information about "GIFT with images" format will be available in near feature. It's testing now. In detail see http://moodle.org/mod/forum/discuss.php?d=118007 (russian language. Use BabelFish or Google Translator)
Hide
Permalink
Howard Miller added a comment -

I broadly agree. A few points.... it's probably not minor, some time needs to be spent tidying the import section up (some has been done already). I suppose this will be another 2.0 thing.

A proposal for making it work needs to be formulated - this should probably done in the developer docs. I would be happy to work on this but it would be later in the year now.

It seems to me that it would be relatively easy for each format to have an optional settings.php file that is used (if it exists) after the format is selected. This is broadly in line with the way this is done elsewhere.

The new version of GIFT really needs a tracker report itself - it would be interesting to see the work that has been done. I have a feeling that GIFT has been pressed about as far as it will go but I am happy to be proved wrong.

Show
Howard Miller added a comment - I broadly agree. A few points.... it's probably not minor, some time needs to be spent tidying the import section up (some has been done already). I suppose this will be another 2.0 thing. A proposal for making it work needs to be formulated - this should probably done in the developer docs. I would be happy to work on this but it would be later in the year now. It seems to me that it would be relatively easy for each format to have an optional settings.php file that is used (if it exists) after the format is selected. This is broadly in line with the way this is done elsewhere. The new version of GIFT really needs a tracker report itself - it would be interesting to see the work that has been done. I have a feeling that GIFT has been pressed about as far as it will go but I am happy to be proved wrong.
Hide
Permalink
Dmitry Pupinin added a comment -

>It seems to me that it would be relatively easy for each format to have an optional settings.php file that is used (if it exists) after the format is selected. This is broadly in line with the way this is done elsewhere.

I talk about options which USER choose, so it should display on import form! Instead settings.php there is optional import_form.php file which implement optional part of import form (if needed). All data from this part of form automatically puting in $this->option[] array, so plugin can use it.

New version of GIFT is creating using improved version of MS Word template... not manually...

PS: Sorry for my english...

Show
Dmitry Pupinin added a comment - >It seems to me that it would be relatively easy for each format to have an optional settings.php file that is used (if it exists) after the format is selected. This is broadly in line with the way this is done elsewhere. I talk about options which USER choose, so it should display on import form! Instead settings.php there is optional import_form.php file which implement optional part of import form (if needed). All data from this part of form automatically puting in $this->option[] array, so plugin can use it. New version of GIFT is creating using improved version of MS Word template... not manually... PS: Sorry for my english...

People

Vote (7)
Watch (4)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.