Issue Details (XML | Word | Printable)

Key: MDL-18848
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Dongsheng Cai
Reporter: Dan Poltawski
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

curl_cache shouldn't be specific to repository

Created: 14/Apr/09 03:58 AM   Updated: 26/Apr/09 11:15 PM
Return to search
Component/s: Repository API
Affects Version/s: 2.0
Fix Version/s: None

Issue Links:
Dependency
 

Participants: Dan Poltawski and Dongsheng Cai
Security Level: None
Resolved date: 24/Apr/09
Affected Branches: MOODLE_20_STABLE


 Description  « Hide
Especially with things like:

$CFG->repository_cache_expire

I want to use $foo = new curl(array('cache' =>true)); for things which aren't the respository API so we should make this unspecific to repository and more a general file cache (or allow repository/different things have different time-outs)

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dongsheng Cai added a comment - 14/Apr/09 10:37 AM
Dan, Thanks for reporting.
I created an options: module_cache for curl class to specify a subclass in cache to store cache files, for example:
$c = new curl(array('cache'=>true, 'module_cache'=>'repository'));
Added a new admin config: curlcache(server/performance), repository_cache_expire has been renamed as repositorycacheexpire.

Dongsheng Cai added a comment - 24/Apr/09 10:49 AM
Please review, thanks

Dan Poltawski added a comment - 26/Apr/09 10:56 PM
Thanks Dongsheng - my only question is do we really need a separate repository cache? Could everything not all have the same defaults/cache directory?