Moodle

Add Anomaly theme to HEAD so others can feel the goodness

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Themes
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

I've been using Anomaly from Patrick Malley for a while, and it's very pleasant to use with very few problems. This could be a new standard theme in Moodle 2.0!

I want to add it to HEAD to make things nicer for all us developers

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin Dougiamas added a comment -

Patrick would you be OK to continue any work on this in HEAD?

Show
Martin Dougiamas added a comment - Patrick would you be OK to continue any work on this in HEAD?
Hide
Permalink
Martin Dougiamas added a comment -

I've put this in HEAD.

Show
Martin Dougiamas added a comment - I've put this in HEAD.
Hide
Permalink
Patrick Malley added a comment -

Good deal. Are you interested in more themes from me?

Show
Patrick Malley added a comment - Good deal. Are you interested in more themes from me?
Hide
Permalink
Martin Dougiamas added a comment -

Patrick: of course !!!

Show
Martin Dougiamas added a comment - Patrick: of course !!!
Hide
Permalink
Eric Merrill added a comment -

Either there are missing files in the checkin, or the readme needs to be updated. The readme indicates there should be additional style_color.css files, but there are none.

Show
Eric Merrill added a comment - Either there are missing files in the checkin, or the readme needs to be updated. The readme indicates there should be additional style_color.css files, but there are none.
Hide
Permalink
Patrick Malley added a comment -

I plan to add more styles_[color].css options. Give me a few weeks to get this done.

Show
Patrick Malley added a comment - I plan to add more styles_[color].css options. Give me a few weeks to get this done.
Hide
Permalink
Daniele Cordella added a comment -

Just new installation from scratch!
Where am I wrong?

Show
Daniele Cordella added a comment - Just new installation from scratch! Where am I wrong?
Hide
Permalink
Patrick Malley added a comment -

Your download must have been older. I have since moved away from using the rounded corner blocks because this theme does not use the Custom Corners engine.

I recommend downloading a fresh copy.

Show
Patrick Malley added a comment - Your download must have been older. I have since moved away from using the rounded corner blocks because this theme does not use the Custom Corners engine. I recommend downloading a fresh copy.
Hide
Permalink
Martin Dougiamas added a comment -

Daniele would be using the one in Moodle core I suspect ...

I tried the new one from your site, Patrick, but I have to say removing those rounded corners took away a lot of what was nice about the theme!

What was the accessibility problem? Is there not some other fix?

Show
Martin Dougiamas added a comment - Daniele would be using the one in Moodle core I suspect ... I tried the new one from your site, Patrick, but I have to say removing those rounded corners took away a lot of what was nice about the theme! What was the accessibility problem? Is there not some other fix?
Hide
Permalink
Patrick Malley added a comment -

To do the rounded corners correctly, I'll just need to turn Custom Corners on and do the styling. Not a big deal to put them back in. I know this is what people prefer.

Show
Patrick Malley added a comment - To do the rounded corners correctly, I'll just need to turn Custom Corners on and do the styling. Not a big deal to put them back in. I know this is what people prefer.
Hide
Permalink
Ralf Hilgenstock added a comment -

Missing styles for course description

Show
Ralf Hilgenstock added a comment - Missing styles for course description
Hide
Permalink
Matt Gibson added a comment -

Nice work. +1 for making this the default theme for new installs.

Show
Matt Gibson added a comment - Nice work. +1 for making this the default theme for new installs.
Hide
Permalink
Patrick Malley added a comment -

Just an update - I've put the rounded corners back in the theme available for download at http://newschoollearning.com/downloads/anomaly.zip - this download file works with Moodle 1.9.x for testing. I will code a different version for 2.0.

Ralf - the styles are purposely missing for the course description block. Moodle 1.9.x does not generate a header for this block, therefore I have nothing to attach the header background image onto. This will not be an issue for 2.0 because I'll be able to create my own wrappers for all sideblocks.

Show
Patrick Malley added a comment - Just an update - I've put the rounded corners back in the theme available for download at http://newschoollearning.com/downloads/anomaly.zip - this download file works with Moodle 1.9.x for testing. I will code a different version for 2.0. Ralf - the styles are purposely missing for the course description block. Moodle 1.9.x does not generate a header for this block, therefore I have nothing to attach the header background image onto. This will not be an issue for 2.0 because I'll be able to create my own wrappers for all sideblocks.
Hide
Permalink
Joseph Rézeau added a comment -

Patrick "this download file works with Moodle 1.9.x for testing. I will code a different version for 2.0. "

1- Does this mean that at the moment (until further notice) we should only test (and report) Anomaly on a moodle 1.9 install (NOT on a 2.0)?

2- Should test reports be reported here in the bug tracker or on the moodle theme forum in this discussion : http://moodle.org/mod/forum/discuss.php?d=129744

Joseph

Show
Joseph Rézeau added a comment - Patrick "this download file works with Moodle 1.9.x for testing. I will code a different version for 2.0. " 1- Does this mean that at the moment (until further notice) we should only test (and report) Anomaly on a moodle 1.9 install (NOT on a 2.0)? 2- Should test reports be reported here in the bug tracker or on the moodle theme forum in this discussion : http://moodle.org/mod/forum/discuss.php?d=129744 Joseph
Hide
Permalink
Patrick Malley added a comment -

Hi Joseph,

Yes. Please only test and report bugs on the 1.9 version of my newest themes. Moodle 2.0 themes require additional coding that is not quite ready to be done yet. For example, we have to work out how we'll remove the layout table for content. Over the next couple of weeks, I'll be working on the 2.0 themes and will post when they're ready for testing. In the meantime, I suppose it's best just to notify me of problems in the forum.

Show
Patrick Malley added a comment - Hi Joseph, Yes. Please only test and report bugs on the 1.9 version of my newest themes. Moodle 2.0 themes require additional coding that is not quite ready to be done yet. For example, we have to work out how we'll remove the layout table for content. Over the next couple of weeks, I'll be working on the 2.0 themes and will post when they're ready for testing. In the meantime, I suppose it's best just to notify me of problems in the forum.
Hide
Permalink
Martin Dougiamas added a comment -

Closing this one. Anomaly is being updated for latest 2.0 as an exemplar by Sam here: MDL-20175

Show
Martin Dougiamas added a comment - Closing this one. Anomaly is being updated for latest 2.0 as an exemplar by Sam here: MDL-20175

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.