[#MDL-18862] formslib: repeat elements should allow element templates (with PATCH!)

Issue Details (XML | Word | Printable)

Key:	MDL-18862
Type:	Bug
Status:	Open
Priority:	Minor
Assignee:	Jamie Pratt
Reporter:	Penny Leach
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

formslib: repeat elements should allow element templates (with PATCH!)

Created: 15/Apr/09 05:23 PM Updated: 27/Feb/10 02:31 PM

Component/s:

Forms Library

Affects Version/s:

1.9.5, 2.0

Fix Version/s:

1.9.8

File Attachments:

0001--UPSTREAM-allow-repeat-elements-to-specify-element.patch (1.0 kB)

Participants:	Jamie Pratt, Penny Leach and Tim Hunt
Security Level:	None
Affected Branches:	MOODLE_19_STABLE, MOODLE_20_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

setting the template in the calling code doesn't work, I guess because the element names get rewritten or something funky. Anyway I made a patch to support passing in the element template in $options['template'].

I'll commit this if someone can review it.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Tim Hunt added a comment - 27/Feb/10 01:23 AM

Same comment as on MDL-18400. Need to patch the Moodle readme as well. I am inclined to commit these, because the Matrix question type looks quite nice.

[ Permalink | « Hide ]

Penny Leach added a comment - 27/Feb/10 02:31 PM

acutally this one doesn't touch quickforms itself, just lib/formslib.php

All content on this web site is made available under the GNU General Public License, unless otherwise stated.