Moodle

Patch Indluded -- Add options to attach a file to an assignment brief, e.g., front sheet, reading materials, question sheet

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.9.4
  • Fix Version/s: None
  • Component/s: Assignment
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

I have written a modification to the upload and uploadsingle assignment types that adds a couple of extra boxes to the form which ask for the file description and file location.

If a file location is set, when the assignment is viewed a link to the file appears below the assignment text. The icon will be appropriately pulled from the theme and the text will come from the file description.

Help buttons and help documents have been supplied. Backups and restores have also been changed to store the settings and files.

NB: The code was written in Windows and exported to Linux to create the diff so there may be excessive changes listed because of carriage return differences. It's my first patch, so I don't exactly know what is normal.

  1. patch.txt
    26/May/09 4:46 PM
    15 kB
    Red Morris
  2. patch.txt
    27/Apr/09 8:21 PM
    465 kB
    Red Morris

Activity

Hide
Ashley Holman added a comment -

Hi Red,

I'm interested to take a look at your patch, but as you said, your patch is not right because of the newline differences.

You can fix this by running dos2unix over the windows file, or diff with -b to ignore whitespace changes.

Thanks

Show
Ashley Holman added a comment - Hi Red, I'm interested to take a look at your patch, but as you said, your patch is not right because of the newline differences. You can fix this by running dos2unix over the windows file, or diff with -b to ignore whitespace changes. Thanks
Hide
Red Morris added a comment -

Thanks Ashley, the -b was what I was missing.

I've not uploaded a new, and much smaller, patch file. Hopefully this one will work a bit better. It certainly looks more like I was expecting.

Red

Show
Red Morris added a comment - Thanks Ashley, the -b was what I was missing. I've not uploaded a new, and much smaller, patch file. Hopefully this one will work a bit better. It certainly looks more like I was expecting. Red
Hide
Red Morris added a comment -

Modified patch file, ignores whitespace changes

Show
Red Morris added a comment - Modified patch file, ignores whitespace changes

People

Vote (2)
Watch (5)

Dates

  • Created:
    Updated: