|
[
Permalink
| « Hide
]
Matt Clarkson added a comment - 29/Apr/09 08:28 AM
First patch was broken - attaching a new version.
I suppose this might work better:
$isfrontpage = false; // Context is part of frontpage if (is_inside_frontpage($context)) {
$isfrontpage = true;
} else if ($context->contextlevel == CONTEXT_COURSE) { Rescheduling, to be fixed right after the 1.9.5 because there is a potential performance problem
hmm, I spent a few hours trying to fix this and also trying to find out all potential problems.
The attached patches are incorrect - they seem to fix only one particular capability setup, it does not deal with negative capability overrides. Major problems are: Sending new patch, I am not really sure if it is a good idea to make this change, so I have added on new config.php switch that enables the patch. Expect big problems especially on large sites where Student role is selected as the default frontpage role. Makes good sense to me. +1 for this as it is.
Just also add a line in config-dist.php and perhaps include a Thanks! hmm, discovered one more potential problem, going to work more on this today - thanks!
grrr, I messed up the number in commit - used MDL-19039 instead, patch in cvs, please note you need to enable one option in config.php, see config-dist.php
petr |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||