Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: 1.9.4
-
Fix Version/s: 1.9.5
-
Component/s: Roles / Access
-
Labels:None
-
Affected Branches:MOODLE_19_STABLE
-
Fixed Branches:MOODLE_19_STABLE
Description
function get_child_contexts($context) {
// ...
case CONTEXT_COURSE:
// ...
$sql = " SELECT ctx.*
FROM {context} ctx
WHERE ctx.path LIKE ?
AND ctx.contextlevel IN (".CONTEXT_MODULE.",".CONTEXT_BLOCK.")
UNION
SELECT ctx.*
FROM {context} ctx
JOIN {groups} g ON (ctx.instanceid=g.id AND ctx.contextlevel=".CONTEXT_GROUP.")
WHERE g.courseid=?
UNION
SELECT ctx.*
FROM {context} ctx
JOIN {block_pinned} b ON (ctx.instanceid=b.blockid AND ctx.contextlevel=".CONTEXT_BLOCK.")
WHERE b.pagetype='course-view'";
That is so wrong!
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Just because it was somewhere in main cvs doesn't mean it is supported. There are incomplete, buggy and highly experimental bits of code in many areas 
We should have removed it long ago, unfortunately we did not. I hope soon there will be 2.0 discussion related to future of roles, permissions, enrolments, parent roles, user profile roles and global groups. There are also known problems with groups at the course level, I suppose there will be some changes in this area too. If you want to use group contexts nobody prevents you from patching your installation, but it is not and never was supported in core. There is a chance that your modifications will not work in 2.0 at all, nobody knows yet. I personally hope we will simplify roles internals, solve majority of current problems and drastically improve performance in 2.0. We could revisit group contexts later, but I personally do not think it is a priority...
We should have removed it long ago, unfortunately we did not. I hope soon there will be 2.0 discussion related to future of roles, permissions, enrolments, parent roles, user profile roles and global groups. There are also known problems with groups at the course level, I suppose there will be some changes in this area too. If you want to use group contexts nobody prevents you from patching your installation, but it is not and never was supported in core. There is a chance that your modifications will not work in 2.0 at all, nobody knows yet. I personally hope we will simplify roles internals, solve majority of current problems and drastically improve performance in 2.0. We could revisit group contexts later, but I personally do not think it is a priority... The sooner we remove unsupported/broken bits the better IMO. The point was to prevent anybody using it and you are the proof we did that too late, not early. The damage of that code was that you started using it thinking it is something standard and supported which it was not at all
In 1.9dev Martin Langhoff refactored all the group mess, unfortunately he was not part of the original group of people hacking roles before, so he just replaced the very broken bits with code that did something because he could not ask Yu who was not working with us any more.
Well, Martin Langhoff is working on different project now too, so from now on only me and Tim will be working on roles, enrolmnets and similar stuff. I was already bugfixing roles bugs in 1.7.x, 1.8.x and also regressions in 1.9.x This year I already spent more than a month thinking and redesigning the roles framework, unfortunately nobody wants to make the final decision - should we go ahead and do the radical changes? Also please note that after the 1.8x groups disaster I am now the only maintainer of groups code in core
1/ Did you read the docs?
see http://docs.moodle.org/en/Development:Roles
"Please note that CONTEXT_PERSONAL (present in 1.7-1.8) was never implemented and was removed in 1.9. CONTEXT_GROUP is also not implemented and **can not** be used. "
2/ Did you publish your code anywhere?
Before removing I did search in contrib, moodle.org forums and also tracker and did not find anything using CONTEXT_GROUP. One of the main benefits of putting code into contrib or reporting issues into tracker is that developers can see what you are doing with the core code. How am I supposed to know you are using some weird code that was never meant to be used? Yes, I can post in moodle.org forums and wait a few days before I get some answers, but very often people overlook these requests or are not subsribed to those forums at all
1/ Did you read the docs?
see http://docs.moodle.org/en/Development:Roles
"Please note that CONTEXT_PERSONAL (present in 1.7-1.8) was never implemented and was removed in 1.9. CONTEXT_GROUP is also not implemented and **can not** be used. "
2/ Did you publish your code anywhere?
Before removing I did search in contrib, moodle.org forums and also tracker and did not find anything using CONTEXT_GROUP. One of the main benefits of putting code into contrib or reporting issues into tracker is that developers can see what you are doing with the core code. How am I supposed to know you are using some weird code that was never meant to be used? Yes, I can post in moodle.org forums and wait a few days before I get some answers, but very often people overlook these requests or are not subsribed to those forums at all 
Adding some of the usual suspects, in the hope that someone other than me will fix this