Details
Bug
Description
getremoteaddr() is designed to get the best IP for the current user, with settings so that the admin can even control the way it works.
We should be using it consistently everywhere, but currently there are still places where we are not and are accessing $_SERVER['REMOTE_ADDR'] directly
ie:
auth/cas/cas_ldap_sync_users.php
auth/db/auth_db_sync_users.php
lib/moodlelib.php
lib/form/recaptcha.php
mnet/remote_client.php
mod/resource/type/file/resource.class.php
mod/resource/type/repository/resource.class.php
Dongsheng, can you carefully fix these for 1.9.5 please?
Issue Links
| This issue has a non-specific relationship to: | ||||
| MDL-13894 | Apache access log ip address and moodle stored ip addresses do not match. |
|
|
|
$_SERVER['REMOTE_ADDR'] is used to check if user is accessing from web, it is OK in this case.
phpmail and pear auth lib use $_SERVER['REMOTE_ADDR'] directly, I think we should change them.
Following files should be changed:
auth/ldap/auth.php
lib/form/recaptcha.php
mod/hotpot/view.php
mod/resource/type/file/resource.class.php
mod/resource/type/repository/resource.class.php