Moodle

cli installer - merge in fixes

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: 1.9.4
  • Fix Version/s: None
  • Component/s: Installation
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

The current cli installer patch (1.9) has some bugs – I've posted some fixes

The fix to cliupgrade so that it sets release properly:
http://dev.laptop.org/git/users/martin/moodle.git/commit/?h=mdl19-xs&id=189c731aed2ebb959107536de20ddc8c660e9ea2

The fix to backuplib upgrades, so that it checks whether we're interactive or not
http://dev.laptop.org/git/users/martin/moodle.git/commit/?h=mdl19-xs&id=9d3f649f0b55267a0027b799c3a4a8dcf1a3283d

This is also handy for anyone using cliupgrade:
http://dev.laptop.org/git/users/martin/moodle.git/commit/?h=mdl19-xs&id=49d9375562d808a7e6d50f7e1ce84d76eeaf91c5

Discussion at http://moodle.org/mod/forum/discuss.php?d=122347

Issue Links

This issue blocks:
MDL-17458 Install & upgrade 2.0 cleanup META Critical Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martín Langhoff added a comment -

More important patches. Without this, Moodle ocassionally misbehaves because it's missing its defaults.

adminlib: introducing admin_new_settings_to_default()
http://dev.laptop.org/git/users/martin/moodle.git/commit/?h=mdl19-xs&id=0caab7ee96bc13646005fb88a1508d2dc0a4681c

cliupgrade: set all the defaults appropriate
http://dev.laptop.org/git/users/martin/moodle.git/commit/?h=mdl19-xs&id=9a208bd63df739fd4105ae2cdb5c6cb0bf63d661

Show
Martín Langhoff added a comment - More important patches. Without this, Moodle ocassionally misbehaves because it's missing its defaults. adminlib: introducing admin_new_settings_to_default() http://dev.laptop.org/git/users/martin/moodle.git/commit/?h=mdl19-xs&id=0caab7ee96bc13646005fb88a1508d2dc0a4681c cliupgrade: set all the defaults appropriate http://dev.laptop.org/git/users/martin/moodle.git/commit/?h=mdl19-xs&id=9a208bd63df739fd4105ae2cdb5c6cb0bf63d661
Hide
Permalink
Martín Langhoff added a comment -

cliupgrade: add support for coursereports, adminreports
http://dev.laptop.org/git/users/martin/moodle.git/commit/?h=mdl19-xs&id=0a0b18858447f0a9925f290759333d055261bbfe

Show
Martín Langhoff added a comment - cliupgrade: add support for coursereports, adminreports http://dev.laptop.org/git/users/martin/moodle.git/commit/?h=mdl19-xs&id=0a0b18858447f0a9925f290759333d055261bbfe
Hide
Permalink
Petr Škoda (skodak) added a comment -

Hello,
I have reviewed your changes, all of them make sense, they are not needed in HEAD because relevant code there is completely rewritten.

Please review the current code in admin/cli/* and file feature requests for any missing features there,
differences:

  • installer is fully separate from upgrade script - major benefit is upgrade.php is a few lines long only and much easier to use/diagnose
  • all the code duplications and tens of IFs were removed
  • installer has fewer options, to be supplemented by more general customisation scripts later
  • different language strings
  • the main web installer was rewritten also a few months ago
  • it is now possible to override site defaults with local/defaults.php - both for installs and upgrades

thanks and ciao

Show
Petr Škoda (skodak) added a comment - Hello, I have reviewed your changes, all of them make sense, they are not needed in HEAD because relevant code there is completely rewritten. Please review the current code in admin/cli/* and file feature requests for any missing features there, differences:
  • installer is fully separate from upgrade script - major benefit is upgrade.php is a few lines long only and much easier to use/diagnose
  • all the code duplications and tens of IFs were removed
  • installer has fewer options, to be supplemented by more general customisation scripts later
  • different language strings
  • the main web installer was rewritten also a few months ago
  • it is now possible to override site defaults with local/defaults.php - both for installs and upgrades
thanks and ciao

People

Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.