|
Hi Tim,
Maxdesign are pretty reliable with regard to web standards and accessibility. http://maxdesign.com.au/presentation/page_layouts/ The CSS-discuss list also has alot of info on this, presented in a table showing solutions that are both fixed and fluid. It also shows browser support: http://css-discuss.incutio.com/?page=ThreeColumnLayouts ~thomas The attached patch (theme_engine_infrastructure.patch) implements most of http://docs.moodle.org/en/Development:Theme_engines_for_Moodle%3F
It does not yet implement any actual rendering methods to replace the ones in weblib. However it does implement all the renderer_engine infrastructure, and a working template renderer. There are unit tests, and PHP doc comments, which hopefully show how it works. (Note, while the template renderer does work, it probably does not have very good performance. Consider it an interesting proof-of-concept until it has had extensive testing.) Code reviews and comments welcome. I would like to commit this tomorrow, and then move on to re-implementing all the weblib print_... functions as moodle_core_renderer methods. Wow, i've reviewed the code and i've learnt bits of php magic I didn't know existed! The only thing I can add is to point out two comment typos:
taking the frist one Another work-in-progress patch (themes_cleanup.patch).
This one cleans up how themes are initialised, and how the theme CSS is processed. The bit I would really like someone to review before tomorrow morning is the change I have made to themes styles.php files. Is this a good idea. (Make sure you also look at the code in deprecated lib to keep old themes working.) I plan to test this a bit more tomorrow, then commit it. Another big work-in-progress patch. (blocks_output.patch)
This moves blocks output into the theme layout.php file, and deletes it from everywhere else. Not quite complete. quiz, lesson and resource module need a bit more work. custom_corners_core_rendererer::block also needs to be updated. At the moment, the diffstat is about -500 lines of code. Note: I've changed:
public function heading($text, $level, $classes = 'main', $id = '') to: public function heading($text, $level = 2, $classes = 'main', $id = '') so, level is now optional and defaults to 2. Commented in HQ chat. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
New Feature
Open
Critical
Implement the theme engines proposal
 |
|
I have just stumbled over this website http://realworldstyle.com
that provides CSS layouts with 2 or 3 columns, header and footer, which even work with NN4 (I'd call that robust...).
hth
Frank