Moodle

Hidden Category Total hides the whole gradebook category from students

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Duplicate
  • Affects Version/s: 1.9.4
  • Fix Version/s: 2.0
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

In the most current patch for 1.9.4 (future 1.9.5) it is virtually impossible to have any hidden grades in the gradebook if you use SUM or SWM.

  • If you hide grade items - they are now included into the Total aggregation for both student and instructor (in regular 1.9 they were included only for the instructor)
  • Solution to move such items into a separate hidden category does not really work, since the Course Total still includes those grades and confuses students (so instructor has to use weights, I guess)
    What would help here, is an option to hide Course Total.
    However, if you hide Category Total = you hide the whole Category from the student view, and if you hide Course Total = you hide the whole gradebook.
    Screenshot is attached. I have hidden the Total for Category 1 there, but in the student view the whole category is gone.

P.S. And, by the way, if you hide just one item - layout of the User report in the student view is severely misaligned. Please see the second screenshot.

Issue Links

This issue duplicates:
MDL-19132 separate category hiding from grade item hidden flag Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Elena Ivanova added a comment -

oh, just found this one: MDL-19028 for the p.s. item. cool

Show
Elena Ivanova added a comment - oh, just found this one: MDL-19028 for the p.s. item. cool
Hide
Permalink
Petr Škoda (skodak) added a comment -

yes, this is by design - the category hiding info is stored in grade item

Show
Petr Škoda (skodak) added a comment - yes, this is by design - the category hiding info is stored in grade item
Hide
Permalink
Petr Škoda (skodak) added a comment -

resolving as duplicate, to be addressed in 2.0
thanks for the report

Show
Petr Škoda (skodak) added a comment - resolving as duplicate, to be addressed in 2.0 thanks for the report
Hide
Permalink
Elena Ivanova added a comment -

p.s. We are developing a small hack, which will add 2 controls in Settings for User and Overview reports.
There will be 2 drop-down menus, stating: Show course total: Hide/Show. Will post it here, in case anyone else wants it.

Show
Elena Ivanova added a comment - p.s. We are developing a small hack, which will add 2 controls in Settings for User and Overview reports. There will be 2 drop-down menus, stating: Show course total: Hide/Show. Will post it here, in case anyone else wants it.
Hide
Permalink
Ratana Lim added a comment -

i find that commenting out the below if block resolved the issue of the whole grade book disappearing when hiding the category total or course total. however, i don't know if it affect other security issue(s). is there any security issue with commenting out the below code block?

grade/report/user.lib.php

202 // If this is a hidden grade category, hide it completely from the user. showhiddenitems: 0 =
203 /*
204 if ($type == 'category' && $grade_object->is_hidden() && !$this->canviewhidden && (
205 $this->showhiddenitems == 0 ||
206 ($this->showhiddenitems == 1 && !$grade_object->is_hiddenuntil()))) { 207 return false; 208 }
209 */

we're planning to update our production code within the next few days after some more testing.

Show
Ratana Lim added a comment - i find that commenting out the below if block resolved the issue of the whole grade book disappearing when hiding the category total or course total. however, i don't know if it affect other security issue(s). is there any security issue with commenting out the below code block? grade/report/user.lib.php 202 // If this is a hidden grade category, hide it completely from the user. showhiddenitems: 0 = 203 /* 204 if ($type == 'category' && $grade_object->is_hidden() && !$this->canviewhidden && ( 205 $this->showhiddenitems == 0 || 206 ($this->showhiddenitems == 1 && !$grade_object->is_hiddenuntil()))) { 207 return false; 208 } 209 */ we're planning to update our production code within the next few days after some more testing.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.